Skip to content

Commit bb672dd

Browse files
committed
Draft 5.0 update process
1 parent 35de303 commit bb672dd

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

docs/update_and_migration/from_4.6/update_to_5.0.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,8 @@ composer recipe:install ibexa/rector --force --reset --yes
353353

354354
TODO: Add other rule sets?
355355

356-
You can add some other rule sets like the Symfony and SensioLabs ones to match newer standards:
356+
You can add some other rule sets like the Symfony and SensioLabs ones to match newer standards.
357+
It's recommended to activate one set at a time, check the output, and decide if kept now, or discarded for a later usage.
357358

358359
```php
359360
//…
@@ -373,13 +374,16 @@ use Rector\Symfony\Set\SensiolabsSetList;
373374
SymfonySetList::SYMFONY_71,
374375
SymfonySetList::SYMFONY_72,
375376
SensiolabsSetList::ANNOTATIONS_TO_ATTRIBUTES,
376-
//DoctrineSetList::DOCTRINE_DBAL_211, //TODO: Useful?
377-
//TODO: Other usefull sets?
377+
//DoctrineSetList::DOCTRINE_DBAL_211, //TODO: Useful? No really. Deprecated. I'll remove it.
378+
//TODO: Other useful sets?
378379
]
379-
)->withAttributesSets(symfony: true);
380+
)
381+
->withAttributesSets(symfony: true) // Duplicate SymfonySetList in witch way? Which rule sets is it adding?
382+
->withPhpSets()
383+
;
380384
```
381385

382-
TODO: Set deprecation and withAttributesSets
386+
TODO: SymfonySetList deprecation and withAttributesSets
383387

384388
#### Update field type identifiers
385389

0 commit comments

Comments
 (0)