Skip to content

Commit 14e322c

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request kubernetes#39547 from copejon/fix-pv-e2e-flake
Automatic merge from submit-queue (batch tested with PRs 39495, 39547) Tag persistent volume PersistentVolume E2E [Volume][Serial][Flaky] **What this PR does / why we need it**: When run parallel with other tests that use PV(C)s, cross-test binding causes flakes. Add `[Serial]` tag. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: f Partly addresses kubernetes#39119 **Special notes for your reviewer**: cc @saad-ali @jsafrane @jeffvance
2 parents dccd073 + f85ef3b commit 14e322c

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/e2e/persistent_volumes.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -560,31 +560,31 @@ var _ = framework.KubeDescribe("PersistentVolumes", func() {
560560
// Create an nfs PV, then a claim that matches the PV, and a pod that
561561
// contains the claim. Verify that the PV and PVC bind correctly, and
562562
// that the pod can write to the nfs volume.
563-
It("should create a non-pre-bound PV and PVC: test write access [Flaky]", func() {
563+
It("should create a non-pre-bound PV and PVC: test write access [Volume][Serial][Flaky]", func() {
564564
pv, pvc = createPVPVC(c, pvConfig, ns, false)
565565
completeTest(f, c, ns, pv, pvc)
566566
})
567567

568568
// Create a claim first, then a nfs PV that matches the claim, and a
569569
// pod that contains the claim. Verify that the PV and PVC bind
570570
// correctly, and that the pod can write to the nfs volume.
571-
It("create a PVC and non-pre-bound PV: test write access [Flaky]", func() {
571+
It("create a PVC and non-pre-bound PV: test write access [Volume][Serial][Flaky]", func() {
572572
pv, pvc = createPVCPV(c, pvConfig, ns, false)
573573
completeTest(f, c, ns, pv, pvc)
574574
})
575575

576576
// Create a claim first, then a pre-bound nfs PV that matches the claim,
577577
// and a pod that contains the claim. Verify that the PV and PVC bind
578578
// correctly, and that the pod can write to the nfs volume.
579-
It("create a PVC and a pre-bound PV: test write access [Flaky]", func() {
579+
It("create a PVC and a pre-bound PV: test write access [Volume][Serial][Flaky]", func() {
580580
pv, pvc = createPVCPV(c, pvConfig, ns, true)
581581
completeTest(f, c, ns, pv, pvc)
582582
})
583583

584584
// Create a nfs PV first, then a pre-bound PVC that matches the PV,
585585
// and a pod that contains the claim. Verify that the PV and PVC bind
586586
// correctly, and that the pod can write to the nfs volume.
587-
It("create a PV and a pre-bound PVC: test write access [Flaky]", func() {
587+
It("create a PV and a pre-bound PVC: test write access [Volume][Serial][Flaky]", func() {
588588
pv, pvc = createPVPVC(c, pvConfig, ns, true)
589589
completeTest(f, c, ns, pv, pvc)
590590
})
@@ -615,7 +615,7 @@ var _ = framework.KubeDescribe("PersistentVolumes", func() {
615615

616616
// Create 2 PVs and 4 PVCs.
617617
// Note: PVs are created before claims and no pre-binding
618-
It("should create 2 PVs and 4 PVCs: test write access[Flaky]", func() {
618+
It("should create 2 PVs and 4 PVCs: test write access [Volume][Serial][Flaky]", func() {
619619
numPVs, numPVCs := 2, 4
620620
pvols, claims = createPVsPVCs(numPVs, numPVCs, c, ns, pvConfig)
621621
waitAndVerifyBinds(c, ns, pvols, claims, true)
@@ -624,7 +624,7 @@ var _ = framework.KubeDescribe("PersistentVolumes", func() {
624624

625625
// Create 3 PVs and 3 PVCs.
626626
// Note: PVs are created before claims and no pre-binding
627-
It("should create 3 PVs and 3 PVCs: test write access[Flaky]", func() {
627+
It("should create 3 PVs and 3 PVCs: test write access [Volume][Serial][Flaky]", func() {
628628
numPVs, numPVCs := 3, 3
629629
pvols, claims = createPVsPVCs(numPVs, numPVCs, c, ns, pvConfig)
630630
waitAndVerifyBinds(c, ns, pvols, claims, true)
@@ -633,7 +633,7 @@ var _ = framework.KubeDescribe("PersistentVolumes", func() {
633633

634634
// Create 4 PVs and 2 PVCs.
635635
// Note: PVs are created before claims and no pre-binding.
636-
It("should create 4 PVs and 2 PVCs: test write access[Flaky]", func() {
636+
It("should create 4 PVs and 2 PVCs: test write access [Volume][Serial][Flaky]", func() {
637637
numPVs, numPVCs := 4, 2
638638
pvols, claims = createPVsPVCs(numPVs, numPVCs, c, ns, pvConfig)
639639
waitAndVerifyBinds(c, ns, pvols, claims, true)
@@ -694,7 +694,7 @@ var _ = framework.KubeDescribe("PersistentVolumes", func() {
694694

695695
// Attach a persistent disk to a pod using a PVC.
696696
// Delete the PVC and then the pod. Expect the pod to succeed in unmounting and detaching PD on delete.
697-
It("should test that deleting a PVC before the pod does not cause pod deletion to fail on PD detach", func() {
697+
It("should test that deleting a PVC before the pod does not cause pod deletion to fail on PD detach [Volume][Serial][Flaky]", func() {
698698
By("Creating the PV and PVC")
699699
pv, pvc = createPVPVC(c, pvConfig, ns, false)
700700
waitOnPVandPVC(c, ns, pv, pvc)
@@ -717,7 +717,7 @@ var _ = framework.KubeDescribe("PersistentVolumes", func() {
717717

718718
// Attach a persistent disk to a pod using a PVC.
719719
// Delete the PV and then the pod. Expect the pod to succeed in unmounting and detaching PD on delete.
720-
It("should test that deleting the PV before the pod does not cause pod deletion to fail on PD detach", func() {
720+
It("should test that deleting the PV before the pod does not cause pod deletion to fail on PD detach [Volume][Serial][Flaky]", func() {
721721
By("Creating the PV and PVC")
722722
pv, pvc = createPVPVC(c, pvConfig, ns, false)
723723
waitOnPVandPVC(c, ns, pv, pvc)

0 commit comments

Comments
 (0)