fix: GetString properly fails when given a mapping variable that does not exist (#3)

* BREAKING CHANGE: private repository moved to public github.

Co-authored-by: sydney-ng <[email protected]>

* Updated to have GetCredentials and allows for v2 mappings

* fix: added tests and renamed files to Go Convention

* Added Deep Search functionality to parse.go

* fix: added tests for v2/mappings (untested)

* added stuff

* Properly returns dictionaries in v2

* fix: mappingsv2_test.go

* fix: updated Readme with user provided part

* fix: README.md

* fix: Updated GetCredentials to take a json string instead of a gjson object. Added test for GetCredentials function

* fix: renaming functions/files

* fix: Update README Supported Search Pattern Types 

added user-provided description in supported search patterns types

* fix: removed comments on cloud_env.go

* fix: removed comments mappingsv1_test.go

* fix: remove comments mappings_test.go

* chore: remove comments mappingsv2_test.go

* fix: updated gopkg to include all libraries

* chore: Update README.md

Fixed wording from Pull Request #3

* chore: fixed indentations to only use spaces

* chore: .go files are correctly formatted

* chore: fix rephrases

* chore: Replaced the term module with package

* Updated README.md with new user-provided pattern

* Added copyright to credentials.go

* chore: fixed copyright alignment

* fix: fixed alignment of filtered credentials

* fix: added travis & fixed linting errors

* fix: removed travis comments

* fix: add user provided for default unknown prefix

* fix: GetString properly fails when given a mapping variable that does not exist

Author: adamcbrown

Gopkg.lock

@@ -248,7 +248,7 @@ func processJSONPath(jsonString string, jsonPath string) (string, bool) {
 	err := json.Unmarshal([]byte(jsonString), &json_data)
 	if err != nil {
 		return "", false
-	} 
+	}
 	res, err := jsonpath.JsonPathLookup(json_data, jsonPath)
 	_, isMap := res.(map[string]interface{})
 	_, isArr := res.([]interface{})
@@ -282,12 +282,16 @@ func GetCredentialsForService(serviceTag, serviceLabel, credentials string) map[
 
 func GetString(name string) (string, bool) {
 	val, ok := loadedMappings[name]
+	if !ok {
+		return "", false
+	}
+
 	_, isStr := val.(string)
-	if ok && !isStr {
+	if !isStr {
 		bytes, _ := json.Marshal(val)
 		return string(bytes), true
 	}
-	return val.(string), ok
+	return val.(string), true
 }
 
 func GetDictionary(name string) gjson.Result {

cloud_env.go

@@ -149,3 +149,14 @@ func TestJsonPathFromEnvVar(t *testing.T) {
 		t.Errorf("Got: \t%s\n Wanted: \t%s\n", testString, "env-var-json-username")
 	}
 }
+
+func TestBadVars(t *testing.T) {
+	setEnvVariable()
+
+	for i := 1; i <= 4; i++ {
+		badStr, ok := GetString("bad_var" + string(i))
+		if badStr != "" || ok {
+			t.Errorf("Did not correctly fail bad string\n")
+		}
+	}
+}