Need to pass 'ibm' env to the webui-vue to theme as IBM #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gtmills opened this issue Apr 29, 2021 · 4 comments

Assignees

Milestone

gtmills commented Apr 29, 2021

https://github.com/openbmc/webui-vue/blob/492875622b39cb2cf04bbb9248b6ed0c52ced2df/docs/themes/env.md

https://github.com/openbmc/webui-vue/blob/7cc1fd48e64ff01dc80eb6323c1175b2fa42a2d0/.env.ibm

gtmills self-assigned this

gtmills mentioned this issue

GUI : Brand GUI as IBM #1042

Closed

14 tasks

gtmills added this to the A.1.212.5 milestone

rfrandse modified the milestones: A.1.212.5, A.1.999

Author

gtmills commented Jun 15, 2021

The IBM router (see which pages are specific to IBM): https://github.com/openbmc/webui-vue/blob/master/src/env/router/ibm.js
Yocto manual: https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html

Like a webui_vue_%.bbappend, kind of like https://github.com/openbmc/openbmc/blob/master/meta-intel-openbmc/meta-common/recipes-phosphor/webui/phosphor-webui_%25.bbappend

Other references:
https://github.ibm.com/openbmc/openbmc/pull/1043/files
https://github.com/openbmc/webui-vue/blob/master/docs/customization/build.md#setup

rfrandse modified the milestones: A.1.212.5, A.1.999

mzipse modified the milestones: A.1.999, A.1.212.5

gtmills assigned patelabhishek9893 and unassigned gtmills

Author

gtmills commented Jul 28, 2021 •

edited

Loading

To unblock test I put a workaround in downstream (like -22).
@patelabhishek9893 has a proper commit here:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/45037

Moved to code review in driver.

Author

gtmills commented Jul 28, 2021

Resolved by https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/45037

Author

gtmills commented Sep 14, 2021

Merged. Closed

gtmills closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment