Skip to content

Commit 76c80c9

Browse files
chore: add rails 8 support (#61)
* chore: add rails 8 support * bundle install * Fix lint * Lint * gem description * Gemfile.lock * Reset lint.yml * Rubocop * Version * Dont use cache * add back cache? * Maybe * gemfile * Debug * debug * Maybe fix
1 parent 14b3317 commit 76c80c9

File tree

6 files changed

+147
-116
lines changed

6 files changed

+147
-116
lines changed

.github/workflows/lint.yml

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,21 @@
11
name: Lint
2-
on: [pull_request]
2+
on:
3+
pull_request:
4+
permissions:
5+
contents: read
6+
pull-requests: write
37
jobs:
48
lint:
5-
name: Rubocop
9+
name: Lint
610
runs-on: ubuntu-latest
711
steps:
812
- name: Check out code
913
uses: actions/checkout@v4
1014
- uses: ruby/setup-ruby@v1
1115
with:
12-
ruby-version: 3.2
16+
bundler-cache: true
1317
- name: rubocop
1418
uses: reviewdog/action-rubocop@v2
1519
with:
16-
rubocop_version: gemfile
17-
rubocop_extensions: rubocop-performance:gemfile rubocop-rails:gemfile rubocop-github:gemfile rubocop-rspec:gemfile
18-
# erb-lint has issues with Alpine (of which is used extensively throughout our products), follow the following issues before re-enabling:
19-
# https://github.com/Shopify/erb-lint/issues/221
20-
# https://github.com/Shopify/better-html/issues/69
21-
# - name: erb-lint
22-
# uses: ./.github/actions/erblint
23-
# with:
24-
# rubocop_extensions: rubocop-performance:gemfile rubocop-rails:gemfile rubocop-github:gemfile
20+
skip_install: true
21+
use_bundler: true

.rubocop.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ AllCops:
1212
SuggestExtensions: false
1313
Exclude:
1414
- 'spec/**/*'
15+
- 'vendor/**/*'
1516

1617
Style/StringLiterals:
1718
EnforcedStyle: double_quotes
@@ -35,3 +36,4 @@ Lint/MissingSuper:
3536
Exclude:
3637
- 'app/components/**/*'
3738
- 'app/services/**/*'
39+

.tool-versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.2
1+
ruby 3.3.6

0 commit comments

Comments
 (0)