Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Commit 8ae0e65

Browse files
committed
Pin DRF dependencies to work with Django 1.8
Pin dependencies `djangorestframework<3.7` and `django-filter<1.1` which are versions that work with Django 1.8. Later versions produce mysterious errors. I had to apply these version constraints in a nasty global way because I could not find a way to specify the versions in setup.py that would actually be respected by setuptools. And I really tried. I also had to apply the pinning in two places: - setup.py for general usage and the go.sh environment - requirements.txt for Travis CI builds.
1 parent 52e59b6 commit 8ae0e65

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
djangorestframework<3.7 # Avoid JSONField errors with Django 1.8
2+
django-filter<1.1 # Avoid get_filter_name() errors with Django 1.8
23

34
-e .[api,brightcove,dev,docs,django18,forms,project,search,test,events,collections]
45

setup.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,13 @@ def find_packages(*paths):
6868
'requests',
6969
'unidecode',
7070
'bleach<2', # Bleach 2 adds a dependency on html5lib>=0.99999999, which breaks our above requirement of html5lib==0.999
71+
72+
# Django 1.8-specific version dependencies that must be here to be
73+
# respected. Ideally these restrictions would go below in the
74+
# 'django18' section but setuptools does not respect them there.
75+
# TODO Remove these once GLAMkit uses Django > 1.8 by default.
76+
'djangorestframework<3.7' # Avoid JSONField errors with Django 1.8
77+
'django-filter<1.1', # Avoid get_filter_name() errors with Django 1.8
7178
],
7279
extras_require={
7380
'api': [

0 commit comments

Comments
 (0)