Merge pull request #118 from icapps/feature/DartCore

Don't add imports for dart:core objects

Author: NicolaVerbeeck

CHANGELOG.md

@@ -1,4 +1,7 @@
 # Changelog
+## [6.0.1] - 2022-10-05
+- Don't create dart:core imports for custom objects
+
 ## [6.0.0] - 2022-10-04
 - Added the ability to specify simple fields in a more compact way, inline.
 

README.md

@@ -464,7 +464,9 @@ UnknownEnumTestObject:
 
 ## Custom object
 
-Support for custom objects that are not generated by the model generator
+Support for custom objects that are not generated by the model generator.
+
+Paths are either local to the project, package specifications (package:...) or dart:core
 
 ```yaml
 CustomObject:

lib/config/yml_generator_config.dart

@@ -305,6 +305,8 @@ class YmlGeneratorConfig {
         return [baseDirectory];
       } else if (path.startsWith('package:')) {
         return [path];
+      } else if (path == 'dart:core') {
+        return [];
       } else {
         return ['$baseDirectory/$path'];
       }
@@ -355,7 +357,7 @@ class YmlGeneratorConfig {
         models.firstWhereOrNull((model) => model.name == itemType.name);
     if (model == null) {
       throw Exception(
-          'getModelByname is null: because `${itemType.name}` was not added to the config file');
+          'getModelByName is null: because `${itemType.name}` was not added to the config file');
     }
     return model;
   }

test/config/yml_generator_config/custom-dart-core.txt

@@ -0,0 +1,9 @@
+Person:
+  type: object
+  properties:
+    address:
+        type: Address
+
+Address:
+  type: custom
+  path: dart:core

test/config/yml_generator_config_test.dart

@@ -281,6 +281,13 @@ void main() {
         expect(config.getPathsForName(pubspecConfig, 'List<Person>').toList(),
             ['model']);
       });
+      test('Get paths with dart:core model', () {
+        final pubspecConfig =
+            PubspecConfig(ConfigTestHelper.getPubspecConfig('normal'));
+        final config = YmlGeneratorConfig(pubspecConfig,
+            ConfigTestHelper.getYmlGeneratorConfig('custom-dart-core'));
+        expect(config.getPathsForName(pubspecConfig, 'Address').toList(), []);
+      });
       test('Get path with invalid model', () {
         final pubspecConfig =
             PubspecConfig(ConfigTestHelper.getPubspecConfig('normal'));
@@ -296,7 +303,7 @@ void main() {
         }
         expect(hasError, true);
         expect(errorMessage,
-            'Exception: getModelByname is null: because `TESTING` was not added to the config file');
+            'Exception: getModelByName is null: because `TESTING` was not added to the config file');
       });
     });
   });