Skip to content

Make the type detector even smarter #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vanlooverenkoen opened this issue Dec 19, 2022 · 0 comments · Fixed by #138
Closed

Make the type detector even smarter #124

vanlooverenkoen opened this issue Dec 19, 2022 · 0 comments · Fixed by #138
Assignees
@jorre127
Labels
P0 Highest prio P2 Medium prio

Comments

@vanlooverenkoen
Copy link
Contributor 

Project:
  path: webservice/projects
  equals_and_hash_code: false
  properties:
    projectId: int
    name: String
    apiKey: String?
    activated: bool
    locales:
      type: array
      items:
        type: WritorLocale
      required: false
      include_if_null: false

could be this:

Project:
  path: webservice/projects
  equals_and_hash_code: false
  properties:
    projectId: int
    name: String
    apiKey: String?
    activated: bool
    locales:
      type: List<WritorLocale>?
      include_if_null: false

because include_if_null:false was added it is not possible to use List<WritorLocale>? anymore
@vanlooverenkoen vanlooverenkoen added the P2 Medium prio label Dec 19, 2022
@vanlooverenkoen vanlooverenkoen added the P0 Highest prio label Aug 10, 2023
jorre127 added a commit that referenced this issue Aug 14, 2023
@jorre127
#124: updated type detector
51f201b
jorre127 added a commit that referenced this issue Aug 14, 2023
@jorre127
#124: updated model generator yaml
ce06181
jorre127 added a commit that referenced this issue Aug 14, 2023
@jorre127
#124: fixed tests
201823e
jorre127 added a commit that referenced this issue Aug 14, 2023
@jorre127
#124: updated changelog + readme
134f221
@jorre127 jorre127 moved this from Todo to In Progress in icapps Flutter OSS Aug 14, 2023
@jorre127 jorre127 self-assigned this Aug 14, 2023
@jorre127 jorre127 mentioned this issue Aug 14, 2023
Merged
@jorre127 jorre127 moved this from In Progress to In Review in icapps Flutter OSS Aug 14, 2023
vanlooverenkoen added a commit that referenced this issue Aug 21, 2023
@vanlooverenkoen
Merge branch 'master' into #124-make-type-detector-smarter
8481a15
jorre127 added a commit that referenced this issue Aug 21, 2023
@jorre127
#124: updated version to 7.0.0
2047296
jorre127 added a commit that referenced this issue Aug 21, 2023
@jorre127
#124: update default config values
d2b18b7
jorre127 added a commit that referenced this issue Aug 21, 2023
@jorre127
#124: added extra tests
37d1ce0
jorre127 added a commit that referenced this issue Aug 22, 2023
@jorre127
#124: updated readme
c4aa333
jorre127 added a commit that referenced this issue Aug 22, 2023
@jorre127
#124: added extra tests
15b6ef8
jorre127 added a commit that referenced this issue Aug 29, 2023
@jorre127
#124: throw error on required added
98696c1
jorre127 added a commit that referenced this issue Aug 29, 2023
@jorre127
#124: fixed tests
159201f
jorre127 added a commit that referenced this issue Aug 29, 2023
@jorre127
#124: fixed configs
8d5eefd
jorre127 added a commit that referenced this issue Aug 30, 2023
@jorre127
#124: check error in tests
fc6e49f
jorre127 added a commit that referenced this issue Aug 30, 2023
@jorre127
#124: formatted code
db19c2b
vanlooverenkoen added a commit that referenced this issue Aug 30, 2023
@vanlooverenkoen
Merge pull request #138 from icapps/#124-make-type-detector-smarter
8feb918 
#124 make type detector smarter
@github-project-automation github-project-automation bot moved this from In Review to Done in icapps Flutter OSS Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorre127 jorre127

Labels
P0 Highest prio P2 Medium prio
Projects
icapps Flutter OSS
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#124 make type detector smarter icapps/flutter-model-generator
2 participants
@vanlooverenkoen @jorre127