-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic connection string #13
Comments
@vitaly-t The widely-used package |
@carnesen There are some open issues related to the use of the connection, so there is some wisdom in making the change:
|
Lots of packages depdend on this specific package. Updating the internsl to use connection-string would require a major version bump. Also, node-postgres still depends on v0.1.3 of this library. |
In the meantime, everyone is required to include the library independently. Also, if you bump the major version, there will be no conflict. |
I would be willing to do a PR for this, if there is any interest. The change would require to leave behind certain proprietary things that do not comply with the URL Connection String Spec. For example, for unix sockets, use proper Example:
or, if the address requires use of
This is necessary, and not just for the sake of a standard, but also to make progress toward supporting multiple hosts, in which you can have a combination of a regular host and a unix socket. |
Biting the bullet on this one, here's the PR that implements it. |
|
I have implemented a generic-version connection-string, which can be used by this library as a special case for PostgreSQL:
segment
as propertydatabase
.protocol
, such aspostgres
+socket
The rest I think would be directly reusable.
The text was updated successfully, but these errors were encountered: