Merge pull request #25 from xnxkzeu/patch-1

icewind1991 · web-flow · commit ff8ea77b1c62 · 2024-10-29T22:09:55.000+01:00
Relaxed memory ordering is enough for atomic counter
diff --git a/src/session.rs b/src/session.rs
@@ -84,7 +84,7 @@ pub struct JobIdCounter(Arc<AtomicU64>);
 impl JobIdCounter {
     #[allow(clippy::should_implement_trait)]
     pub fn next(&self) -> JobId {
-        JobId(self.0.fetch_add(1, Ordering::SeqCst))
+        JobId(self.0.fetch_add(1, Ordering::Relaxed))
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ pub struct JobIdCounter(Arc<AtomicU64>);`
`84`	`84`	`impl JobIdCounter {`
`85`	`85`	`#[allow(clippy::should_implement_trait)]`
`86`	`86`	`pub fn next(&self) -> JobId {`
`87`		`- JobId(self.0.fetch_add(1, Ordering::SeqCst))`
	`87`	`+ JobId(self.0.fetch_add(1, Ordering::Relaxed))`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`