Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputParameters applyParameter should error if no parameter fit #27556

Open
GiudGiud opened this issue May 6, 2024 · 0 comments · May be fixed by #29734
Open

InputParameters applyParameter should error if no parameter fit #27556

GiudGiud opened this issue May 6, 2024 · 0 comments · May be fixed by #29734
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented May 6, 2024

Bug Description

While coding physics I m moving a fair amount of parameters from one object to another.
There is no reason to use applyParameter if none of the parameters are relevant. it should error, telling the developer that the call was either useless or worse, not working as expected

Steps to Reproduce

Use applyparam in an action, with none of the action parameters matching an object's (created by the action)

Impact

Easier development

[Optional] Diagnostics

No response
@GiudGiud GiudGiud added P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations. labels May 6, 2024
@GiudGiud GiudGiud mentioned this issue May 15, 2024
Open
DanielYankura added a commit to DanielYankura/moose that referenced this issue Jan 22, 2025
@DanielYankura
added error for when no parameter fits
e642729 
- added check to applyParameter that throws an error if the provided param does not match any known param
- added to applyParameter unit test to ensure an error is thrown

closes idaholab#27556
@DanielYankura DanielYankura linked a pull request Jan 22, 2025 that will close this issue
Open
DanielYankura added a commit to DanielYankura/moose that referenced this issue Jan 28, 2025
@DanielYankura
added error for when no parameter fits
fd5fb18 
- added check to applyParameter that throws an error if the provided param does not match any known param
- added to applyParameter unit test to ensure an error is thrown

closes idaholab#27556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added error for when no parameter fits DanielYankura/moose
2 participants
@lindsayad @GiudGiud