Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify water_fp for PorousFlowBrine in PorousFlowFullySaturated #29848

Open
hsheldon opened this issue Feb 9, 2025 · 2 comments
Labels
T: task An enhancement to the software.

Comments

@hsheldon
Copy link
Contributor

hsheldon commented Feb 9, 2025

Motivation

Need to customise the FluidProperties UserObject for water to avoid P going out of range, e.g. by using tabulated fluid properties to extend the range of Water97. Currently if using PorousFlowBrine through the PorousFlowFullySaturated action there is no option to specify the water_fp that is used in PorousFlowBrine, hence it uses the default (I think this is Water97) which does not cover my required P range. Can achieve the desired outcome by specifying everything manually, but would prefer to use the action for simplicity.

Design

Add water_fp as an optional param for PorousFlowFullySaturated when using fluid_properties_type = PorousFlowBrine. Pass water_fp to PorousFlowActionBase::addBrineMaterial.

Impact

Should have no impact on validity of existing input files

@hsheldon hsheldon added the T: task An enhancement to the software. label Feb 9, 2025
@hsheldon
Copy link
Contributor Author

hsheldon commented Feb 9, 2025

@WilkAndy interested in your thoughts on this, maybe there was a reason why it wasn't done.

@cpgr
Copy link
Contributor

cpgr commented Feb 10, 2025

It's possible that the water_fp param was added to PorousFlowBrine after the PorousFlowFullySaturated action was created and was never added there too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

2 participants