-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
T: taskAn enhancement to the software.An enhancement to the software.
Description
Motivation
ConservativeAdvection
uses _u_nodal
in the upwinding formulation. I have a downstream application that is using the log transform of u
, thus needs to plug in exp(u_nodal)
into upwinding. Instead of making function ConservativeAdvection::fullUpwind
virtual (which takes an enum and makes inheritance difficult) I would rather make a virtual getter function for _u_nodal
I can pass a exp transformed value in downstream apps.
Design
Make virtual GenericReal<is_ad> getUNodal(unsigned int n) { return _u_nodal[n]; }
in ConservativeAdvection
.
Impact
More downstream application flexibility.
Metadata
Metadata
Assignees
Labels
T: taskAn enhancement to the software.An enhancement to the software.