Skip to content

Commit b8e9211

Browse files
committed
XMap 1.1.1 Minor Release
* XMap 1.1.1 Minor Release. * Fix Bugs: * Fix the memory leakage issue
1 parent 70af73b commit b8e9211

File tree

7 files changed

+17
-12
lines changed

7 files changed

+17
-12
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,8 @@
2222
* XMap 1.1.0 Major Release.
2323
* New Features:
2424
* DNS scan modules enabled (base module: `-M dnsx`, query for software version: `-M dnsv`, spoofing source address: `-M dnsf`, and so on)
25+
26+
# 1.1.1 2022-09-22
27+
* XMap 1.1.1 Minor Release.
28+
* Fix Bugs:
29+
* Fix the memory leakage issue

src/probe_modules/module_dnsf.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -963,7 +963,7 @@ int dnsf_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *dst_ip,
963963
domains_f[index]);
964964

965965
// dns packet
966-
if (!qnames_f[index]) free(qnames_f[index]);
966+
free(qnames_f[index]);
967967

968968
qname_lens_f[index] = domain_to_qname_f(&qnames_f[index], new_domain);
969969
dns_packet_lens_f[index] = sizeof(dns_header) + qname_lens_f[index] +
@@ -974,7 +974,7 @@ int dnsf_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *dst_ip,
974974
return EXIT_FAILURE;
975975
}
976976

977-
if (!dns_packets_f[index]) free(dns_packets_f[index]);
977+
free(dns_packets_f[index]);
978978

979979
dns_packets_f[index] = xmalloc(dns_packet_lens_f[index]);
980980
dns_header *dns_header_p = (dns_header *) dns_packets_f[index];

src/probe_modules/module_dnsr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ int dnsr_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
947947
domains_r[index]);
948948

949949
// dns packet
950-
if (!qnames_r[index]) free(qnames_r[index]);
950+
free(qnames_r[index]);
951951

952952
qname_lens_r[index] = domain_to_qname_r(&qnames_r[index], new_domain);
953953
dns_packet_lens_r[index] = sizeof(dns_header) + qname_lens_r[index] +
@@ -958,7 +958,7 @@ int dnsr_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
958958
return EXIT_FAILURE;
959959
}
960960

961-
if (!dns_packets_r[index]) free(dns_packets_r[index]);
961+
free(dns_packets_r[index]);
962962

963963
dns_packets_r[index] = xmalloc(dns_packet_lens_r[index]);
964964
dns_header *dns_header_p = (dns_header *) dns_packets_r[index];

src/probe_modules/module_dnss.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -969,7 +969,7 @@ int dnss_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
969969
domains_s[index]);
970970

971971
// dns packet
972-
if (!qnames_s[index]) free(qnames_s[index]);
972+
free(qnames_s[index]);
973973

974974
qname_lens_s[index] = domain_to_qname_s(&qnames_s[index], new_domain);
975975
dns_packet_lens_s[index] = sizeof(dns_header) + qname_lens_s[index] +
@@ -980,7 +980,7 @@ int dnss_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
980980
return EXIT_FAILURE;
981981
}
982982

983-
if (!dns_packets_s[index]) free(dns_packets_s[index]);
983+
free(dns_packets_s[index]);
984984

985985
dns_packets_s[index] = xmalloc(dns_packet_lens_s[index]);
986986
dns_header *dns_header_p = (dns_header *) dns_packets_s[index];

src/probe_modules/module_dnsv.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@ int dnsv_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
962962
domains_v[index]);
963963

964964
// dns packet
965-
if (!qnames_v[index]) free(qnames_v[index]);
965+
free(qnames_v[index]);
966966

967967
qname_lens_v[index] = domain_to_qname_v(&qnames_v[index], new_domain);
968968
dns_packet_lens_v[index] = sizeof(dns_header) + qname_lens_v[index] +
@@ -973,7 +973,7 @@ int dnsv_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
973973
return EXIT_FAILURE;
974974
}
975975

976-
if (!dns_packets_v[index]) free(dns_packets_v[index]);
976+
free(dns_packets_v[index]);
977977

978978
dns_packets_v[index] = xmalloc(dns_packet_lens_v[index]);
979979
dns_header *dns_header_p = (dns_header *) dns_packets_v[index];

src/probe_modules/module_dnsx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ int dnsx_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
995995
domains_x[index]);
996996

997997
// dns packet
998-
if (!qnames_x[index]) free(qnames_x[index]);
998+
free(qnames_x[index]);
999999

10001000
qname_lens_x[index] = domain_to_qname_x(&qnames_x[index], new_domain);
10011001
dns_packet_lens_x[index] = sizeof(dns_header) + qname_lens_x[index] +
@@ -1006,7 +1006,7 @@ int dnsx_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
10061006
return EXIT_FAILURE;
10071007
}
10081008

1009-
if (!dns_packets_x[index]) free(dns_packets_x[index]);
1009+
free(dns_packets_x[index]);
10101010

10111011
dns_packets_x[index] = xmalloc(dns_packet_lens_x[index]);
10121012
dns_header *dns_header_p = (dns_header *) dns_packets_x[index];

src/probe_modules/module_dnsz.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ int dnsz_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
947947
domains_z[index]);
948948

949949
// dns packet
950-
if (!qnames_z[index]) free(qnames_z[index]);
950+
free(qnames_z[index]);
951951

952952
qname_lens_z[index] = domain_to_qname_z(&qnames_z[index], new_domain);
953953
dns_packet_lens_z[index] = sizeof(dns_header) + qname_lens_z[index] +
@@ -958,7 +958,7 @@ int dnsz_make_packet(void *buf, size_t *buf_len, ipaddr_n_t *src_ip,
958958
return EXIT_FAILURE;
959959
}
960960

961-
if (!dns_packets_z[index]) free(dns_packets_z[index]);
961+
free(dns_packets_z[index]);
962962

963963
dns_packets_z[index] = xmalloc(dns_packet_lens_z[index]);
964964
dns_header *dns_header_p = (dns_header *) dns_packets_z[index];

0 commit comments

Comments
 (0)