Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor class CheckIntegrity(Thread) to use local-space variables #36

Open
Zerpet opened this issue Jun 14, 2016 · 0 comments
Open

Refactor class CheckIntegrity(Thread) to use local-space variables #36

Zerpet opened this issue Jun 14, 2016 · 0 comments
Labels

Comments

@Zerpet
Copy link
Collaborator

Zerpet commented Jun 14, 2016

We thought that class CheckIntegrity was using local variables since we created references in the __init__() constructor to the global variables. However, those are just references to the global object, not an actual private copy.

At the moment there is no risk or race-conditions because we don't modify the object with the thread information after initializing and starting the threads. However, we should do this thread-safe and implement thread-local variables.

@Zerpet Zerpet added the bug label Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant