Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttachmentLink occurence is bogus in RFC9559 #930

Open
robUx4 opened this issue Dec 15, 2024 · 2 comments · May be fixed by #932
Open

AttachmentLink occurence is bogus in RFC9559 #930

robUx4 opened this issue Dec 15, 2024 · 2 comments · May be fixed by #932
Labels
errata-rfc9559 spec_main Main Matroska spec document target

Comments

@robUx4
Copy link
Contributor

robUx4 commented Dec 15, 2024

The max value to 1 was introduced in 2c0a14d and then turned into a maxOccurs value in 6210296.

We can link multiple attachment (fonts) to a single track.
@robUx4 robUx4 added spec_main Main Matroska spec document target errata-rfc9559 labels Dec 15, 2024
robUx4 added a commit to robUx4/matroska-specification that referenced this issue Dec 15, 2024
@robUx4
fix AttachmentLink occurence
d1488d7 
A track can reference multiple attachments.

The max value to 1 was introduced in 2c0a14d and then turned into a `maxOccurs` value in  6210296.

Fixes ietf-wg-cellar#930
@robUx4 robUx4 linked a pull request Dec 15, 2024 that will close this issue
Open
@robUx4
Copy link
Contributor Author

robUx4 commented Dec 15, 2024

As far as I can see, KaxTrackAttachmentLink has always been considered as unique in libmatroska. This change will introduce a behavior change there. cc @mbunkus

@mbunkus
Copy link
Contributor

mbunkus commented Dec 15, 2024

MKVToolNix doesn't use this element (as in, it doesn't write it). It can show it via mkvinfo, obviously, but that's it. Therefore changes to maxOccurs wouldn't affect me.

robUx4 added a commit to robUx4/matroska-specification that referenced this issue Jan 26, 2025
@robUx4
[errata] allow multiple AttachmentLink per track
3c38bbf 
Fixes ietf-wg-cellar#930
@robUx4 robUx4 mentioned this issue Jan 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
errata-rfc9559 spec_main Main Matroska spec document target
Projects
Matroska specifications
Status: No status
Milestone
No milestone
2 participants
@mbunkus @robUx4