Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relies on simple heuristic for re-running setup #7

Open
igemnace opened this issue Jan 10, 2018 · 0 comments
Open

Relies on simple heuristic for re-running setup #7

igemnace opened this issue Jan 10, 2018 · 0 comments

Comments

@igemnace
Copy link
Owner

#3 has been resolved by having makery#Setup run in a buffer-local manner, then running config detection with an autocommand on BufRead,BufNewFile.

While this works in the simple cases I've tested, it doesn't seem as robust as it can be. For comparison, Projectionist runs config detection on a long list of autocommand events.

While duplicating Projectionist's effort would be a waste (better to just do #5), some of those might be required to catch edge cases. Catching buftype in commit 1ac07e8 was already a concession here, for example, since without it, opening the quickfix kept bringing up Makery warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant