Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better tests are needed #3

Open
illabo opened this issue Oct 9, 2020 · 0 comments
Open

Better tests are needed #3

illabo opened this issue Oct 9, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@illabo
Copy link
Owner

illabo commented Oct 9, 2020

All the checks now are performed within a single method in Example/Tests/Tests.swift. This test may be considered integration testing as it tests functioning of the library within example app.

  • Tests needs to be enhanced and at least all the current test cases in Example/Tests/Tests.swift should be moved to separate methods.
  • Some unit tests better be added to IIDadata/Tests/IIDadataTests/IIDadataTests.swift to validate the correctness of the library internals.
@illabo illabo added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@illabo