Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to do list #35

Open
9 of 13 tasks
elisvb opened this issue Apr 21, 2021 · 0 comments
Open
9 of 13 tasks

to do list #35

elisvb opened this issue Apr 21, 2021 · 0 comments

Comments

@elisvb
Copy link
Member

elisvb commented Apr 21, 2021

Potential improvements to be made, following the comments from the framework meeting and discussions after:

  • An option could be added to look at an alternative option (e.g., weight by sample size)
    -> decided not to do this for now (added layer of complexity with limited importance)
  • Assure the LF props always sum to one
  • minimal number of fish as a threshold
  • weigh the samples the Hugues way
    -> will not do this. ends up model like, cannot be done "blindly" in a function.
    -> could weigh in function of the hierarchical level used?? arbitrary but perhaps interesting sensitivity run.
  • resolve the 'AL vs LF' mismatch
  • add plot functions for quality control directly in the package
  • add the spay/spya functions
  • standard errors for weight-and length-at-age (though this would not include 'bad sampling')
  • add matrix smoothing model
  • possibility to use get.samples only for length-frequencies, or to have lf and al being the same (no subsample)
  • Make Demo (within package or as external Rproject)
  • parallel funcitonality
  • testthat so to make sure metadata is all of the same encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant