[eslint] enable object-shorthand, space-before-function-paren

Author: ljharb

.eslintrc

@@ -31,13 +31,23 @@
         "no-shadow": 1,
         "no-var": 2,
         "object-curly-spacing": [2, "always"],
+        "object-shorthand": ["error", "always", {
+            "ignoreConstructors": false,
+            "avoidQuotes": true,
+        }],
         "one-var": [2, "never"],
         "prefer-const": 2,
         "quotes": [2, "single", {
             "allowTemplateLiterals": true,
             "avoidEscape": true,
         }],
         "semi": [2, "always"],
+        "space-before-function-paren": ["error", {
+            "anonymous": "always",
+            "named": "never",
+            "asyncArrow": "always",
+        }],
+  
         "eslint-plugin/consistent-output": [
             "error",
             "always",

resolvers/webpack/index.js

@@ -163,7 +163,7 @@ exports.resolve = function (source, file, settings) {
 const MAX_CACHE = 10;
 const _cache = [];
 function getResolveSync(configPath, webpackConfig, cwd) {
-  const cacheKey = { configPath: configPath, webpackConfig: webpackConfig };
+  const cacheKey = { configPath, webpackConfig };
   let cached = find(_cache, function (entry) { return isEqual(entry.key, cacheKey); });
   if (!cached) {
     cached = {
@@ -265,7 +265,7 @@ function createWebpack1ResolveSync(webpackRequire, resolveConfig, plugins) {
   resolver.apply(
     resolveConfig.packageAlias
       ? new DirectoryDescriptionFileFieldAliasPlugin('package.json', resolveConfig.packageAlias)
-      : function() {},
+      : function () {},
     new ModuleAliasPlugin(resolveConfig.alias || {}),
     makeRootPlugin(ModulesInRootPlugin, 'module', resolveConfig.root),
     new ModulesInDirectoriesPlugin(
@@ -302,7 +302,7 @@ function createWebpack1ResolveSync(webpackRequire, resolveConfig, plugins) {
 
   resolver.apply.apply(resolver, resolvePlugins);
 
-  return function() {
+  return function () {
     return resolver.resolveSync.apply(resolver, arguments);
   };
 }
@@ -391,7 +391,7 @@ function findExternal(source, externals, context, resolveSync) {
 }
 
 function findConfigPath(configPath, packageDir) {
-  const extensions = Object.keys(interpret.extensions).sort(function(a, b) {
+  const extensions = Object.keys(interpret.extensions).sort(function (a, b) {
     return a === '.js' ? -1 : b === '.js' ? 1 : a.length - b.length;
   });
   let extension;

resolvers/webpack/test/config.js

@@ -101,7 +101,7 @@ describe('config', function () {
       .and.equal(path.join(__dirname, 'files', 'some', 'goofy', 'path', 'foo.js'));
   });
 
-  it('finds the config at option env when config is a function', function() {
+  it('finds the config at option env when config is a function', function () {
     const settings = {
       config: require(path.join(__dirname, './files/webpack.function.config.js')),
       env: {
@@ -113,7 +113,7 @@ describe('config', function () {
       .and.equal(path.join(__dirname, 'files', 'some', 'goofy', 'path', 'bar.js'));
   });
 
-  it('finds the config at option env when config is an array of functions', function() {
+  it('finds the config at option env when config is an array of functions', function () {
     const settings = {
       config: require(path.join(__dirname, './files/webpack.function.config.multiple.js')),
       env: {
@@ -125,7 +125,7 @@ describe('config', function () {
       .and.equal(path.join(__dirname, 'files', 'some', 'goofy', 'path', 'bar.js'));
   });
 
-  it('passes argv to config when it is a function', function() {
+  it('passes argv to config when it is a function', function () {
     const settings = {
       config: require(path.join(__dirname, './files/webpack.function.config.js')),
       argv: {
@@ -137,7 +137,7 @@ describe('config', function () {
       .and.equal(path.join(__dirname, 'files', 'some', 'bar', 'bar.js'));
   });
 
-  it('passes a default empty argv object to config when it is a function', function() {
+  it('passes a default empty argv object to config when it is a function', function () {
     const settings = {
       config: require(path.join(__dirname, './files/webpack.function.config.js')),
       argv: undefined,
@@ -146,7 +146,7 @@ describe('config', function () {
     expect(function () { resolve('baz', file, settings); }).to.not.throw(Error);
   });
 
-  it('prevents async config using', function() {
+  it('prevents async config using', function () {
     const settings = {
       config: require(path.join(__dirname, './files/webpack.config.async.js')),
     };

src/rules/default.js

@@ -10,7 +10,7 @@ module.exports = {
     schema: [],
   },
 
-  create: function (context) {
+  create(context) {
 
     function checkDefault(specifierType, node) {
 

src/rules/dynamic-import-chunkname.js

@@ -24,7 +24,7 @@ module.exports = {
     }],
   },
 
-  create: function (context) {
+  create(context) {
     const config = context.options[0];
     const { importFunctions = [] } = config || {};
     const { webpackChunknameFormat = '[0-9a-zA-Z-_/.]+' } = config || {};

src/rules/export.js

@@ -54,7 +54,7 @@ module.exports = {
     schema: [],
   },
 
-  create: function (context) {
+  create(context) {
     const namespace = new Map([[rootProgram, new Map()]]);
 
     function addNamed(name, node, parent, isType) {

src/rules/exports-last.js

@@ -15,9 +15,9 @@ module.exports = {
     schema: [],
   },
 
-  create: function (context) {
+  create(context) {
     return {
-      Program: function ({ body }) {
+      Program({ body }) {
         const lastNonExportStatementIndex = body.reduce(function findLastIndex(acc, item, index) {
           if (isNonExportStatement(item)) {
             return index;

src/rules/extensions.js

@@ -103,7 +103,7 @@ module.exports = {
     },
   },
 
-  create: function (context) {
+  create(context) {
 
     const props = buildProperties(context);
 

src/rules/first.js

@@ -21,8 +21,8 @@ module.exports = {
     ],
   },
 
-  create: function (context) {
-    function isPossibleDirective (node) {
+  create(context) {
+    function isPossibleDirective(node) {
       return node.type === 'ExpressionStatement' &&
         node.expression.type === 'Literal' &&
         typeof node.expression.value === 'string';

src/rules/named.js

@@ -21,7 +21,7 @@ module.exports = {
     ],
   },
 
-  create: function (context) {
+  create(context) {
     const options = context.options[0] || {};
 
     function checkSpecifiers(key, type, node) {