Skip to content

Commit 28d1217

Browse files
author
daniela
committed
IWF-963: fix lint issues
1 parent fa061a2 commit 28d1217

File tree

3 files changed

+22
-12
lines changed

3 files changed

+22
-12
lines changed

iwf/tests/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@
2828
from iwf.tests.workflows.state_options_override_workflow import (
2929
StateOptionsOverrideWorkflow,
3030
)
31-
from iwf.tests.workflows.state_options_workflow import (StateOptionsWorkflow1,
32-
StateOptionsWorkflow2)
31+
from iwf.tests.workflows.state_options_workflow import (
32+
StateOptionsWorkflow1,
33+
StateOptionsWorkflow2,
34+
)
3335
from iwf.tests.workflows.timer_workflow import TimerWorkflow
3436
from iwf.tests.workflows.wait_for_state_with_state_execution_id_workflow import (
3537
WaitForStateWithStateExecutionIdWorkflow,

iwf/tests/test_workflow_state_options.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,15 @@
77
from iwf.iwf_api.models import (
88
PersistenceLoadingPolicy,
99
PersistenceLoadingType,
10-
WorkflowStateOptions as IdlWorkflowStateOptions, RetryPolicy,
10+
WorkflowStateOptions as IdlWorkflowStateOptions,
11+
RetryPolicy,
1112
WaitUntilApiFailurePolicy,
1213
)
1314
from iwf.tests.worker_server import registry
14-
from iwf.tests.workflows.state_options_workflow import (StateOptionsWorkflow1,
15-
StateOptionsWorkflow2)
15+
from iwf.tests.workflows.state_options_workflow import (
16+
StateOptionsWorkflow1,
17+
StateOptionsWorkflow2,
18+
)
1619
from iwf.workflow_options import WorkflowOptions
1720
from iwf.workflow_state_options import WorkflowStateOptions, _to_idl_state_options
1821
from ..errors import WorkflowFailed
@@ -44,6 +47,7 @@ def test_convert_to_idl(self):
4447
assert non_empty.state_id == "state-id-2"
4548

4649
"""Test that proceed_to_execute_when_wait_until_retry_exhausted correctly handles both enum values."""
50+
4751
def test_proceed_to_execute_when_wait_until_retry_exhausted(self):
4852
retry_policy = RetryPolicy(maximum_attempts=1)
4953

@@ -53,22 +57,29 @@ def test_proceed_to_execute_when_wait_until_retry_exhausted(self):
5357
wait_until_api_retry_policy=retry_policy,
5458
)
5559
result_proceed = _to_idl_state_options(False, options_proceed, {})
56-
assert result_proceed.wait_until_api_failure_policy == WaitUntilApiFailurePolicy.PROCEED_ON_FAILURE
60+
assert (
61+
result_proceed.wait_until_api_failure_policy
62+
== WaitUntilApiFailurePolicy.PROCEED_ON_FAILURE
63+
)
5764

5865
# Test FAIL_WORKFLOW_ON_FAILURE
5966
options_fail = WorkflowStateOptions(
6067
proceed_to_execute_when_wait_until_retry_exhausted=WaitUntilApiFailurePolicy.FAIL_WORKFLOW_ON_FAILURE,
6168
wait_until_api_retry_policy=retry_policy,
6269
)
6370
result_fail = _to_idl_state_options(False, options_fail, {})
64-
assert result_fail.wait_until_api_failure_policy == WaitUntilApiFailurePolicy.FAIL_WORKFLOW_ON_FAILURE
71+
assert (
72+
result_fail.wait_until_api_failure_policy
73+
== WaitUntilApiFailurePolicy.FAIL_WORKFLOW_ON_FAILURE
74+
)
6575

6676
# Test with None/unset value
6777
options = WorkflowStateOptions()
6878
result = _to_idl_state_options(False, options, {})
6979
# By default, wait_until_api_failure_policy should not be set when proceed_to_execute_when_wait_until_retry_exhausted is None
7080
# The IWF service will use FAIL_WORKFLOW_ON_FAILURE by default
7181
from iwf.iwf_api.types import Unset
82+
7283
self.assertTrue(isinstance(result.wait_until_api_failure_policy, Unset))
7384

7485
def test_proceed_on_failure(self):
@@ -82,10 +93,7 @@ def test_proceed_on_failure(self):
8293
)
8394
output = self.client.wait_for_workflow_completion(wf_id)
8495

85-
assert (
86-
output
87-
== "InitState1_execute_completed"
88-
)
96+
assert output == "InitState1_execute_completed"
8997

9098
def test_fail_workflow_on_failure(self):
9199
wf_id = f"{inspect.currentframe().f_code.co_name}-{time.time_ns()}"

iwf/tests/workflows/state_options_workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class StateOptionsWorkflow1(ObjectWorkflow):
7272
def get_workflow_states(self) -> StateSchema:
7373
return StateSchema.with_starting_state(InitState1())
7474

75+
7576
class StateOptionsWorkflow2(ObjectWorkflow):
7677
def get_workflow_states(self) -> StateSchema:
7778
return StateSchema.with_starting_state(InitState2())
78-

0 commit comments

Comments
 (0)