If (err) return callback(null)

[alessioalex]

This module worked fine a couple of days ago, but now it does not show me the mappings (but I can assign private => public ports) so I debugged a bit. Turns out that at the following line the callback does not include the error:

https://github.com/indutny/node-nat-upnp/blob/master/lib/nat-upnp/client.js#L89-L92

Shouldn't it return the error?

Anyway in my case the request body is the following:

{ '@':
   { 'xmlns:SOAP-ENV': 'http://schemas.xmlsoap.org/soap/envelope/',
     'SOAP-ENV:encodingStyle': 'http://schemas.xmlsoap.org/soap/encoding/' },
  'SOAP-ENV:Body':
   { 'SOAP-ENV:Fault':
      { faultcode: 'SOAP-ENV:Client',
        faultstring: 'UPnPError',
        detail:
         { UPnPError:
            { '@': { xmlns: 'urn:schemas-upnp-org:control-1-0' },
              errorCode: '402',
              errorDescription: 'Invalid NewPortMappingIndex' } } } } }

Any thoughts?

[indutny]

Hm... it should not return a error here, because it is async.whilst, anyway what is the request body, could you try printing it out?

[alessioalex]

@indutny well the error comes from gateway.run and the stack shows me that it's created here:

https://github.com/indutny/node-nat-upnp/blob/master/lib/nat-upnp/device.js#L150-L152

That's the request body I was referring to, sorry for not being more clear. The status code is 500.

[indutny]

Could you please log body here?

[alessioalex]

That's the one from my previous reply:

{ '@':
   { 'xmlns:SOAP-ENV': 'http://schemas.xmlsoap.org/soap/envelope/',
     'SOAP-ENV:encodingStyle': 'http://schemas.xmlsoap.org/soap/encoding/' },
  'SOAP-ENV:Body':
   { 'SOAP-ENV:Fault':
      { faultcode: 'SOAP-ENV:Client',
        faultstring: 'UPnPError',
        detail:
         { UPnPError:
            { '@': { xmlns: 'urn:schemas-upnp-org:control-1-0' },
              errorCode: '402',
              errorDescription: 'Invalid NewPortMappingIndex' } } } } }

[alessioalex]

Or were you reffering to the body sent and not received?

[indutny]

Yeah, body that was sent.

[alessioalex]

Ok, will let you know as soon as I get home. Thanks a lot!

[alessioalex]

This is the body that seems to be sent:

'<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">\n<SOAP-ENV:Body>\n<SOAP-ENV:Fault>\n<faultcode>SOAP-ENV:Client</faultcode>\n<faultstring>UPnPError</faultstring>\n<detail>\n<UPnPError xmlns="urn:schemas-upnp-org:control-1-0">\n<errorCode>402</errorCode>\n<errorDescription>Invalid NewPortMappingIndex</errorDescription>\n</UPnPError>\n</detail>\n</SOAP-ENV:Fault>\n</SOAP-ENV:Body>\n</SOAP-ENV:Envelope>\n'

[indutny]

Seems to be a response body...

[indutny]

You should probably try to print this var: https://github.com/indutny/node-nat-upnp/blob/master/lib/nat-upnp/device.js#L144

[alessioalex]

Sorry my bad, I was logging in the wrong location.

The thing is that now everything seems to be ok, I'm not sure what happened the other time. I will let you know next time I encounter the problem.

====================================
'<?xml version="1.0"?><s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:GetGenericPortMappingEntry xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1"><NewPortMappingIndex>1</NewPortMappingIndex></u:GetGenericPortMappingEntry></s:Body></s:Envelope>'
====================================
====================================
'<?xml version="1.0"?><s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:GetGenericPortMappingEntry xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1"><NewPortMappingIndex>2</NewPortMappingIndex></u:GetGenericPortMappingEntry></s:Body></s:Envelope>'
====================================
====================================
'<?xml version="1.0"?><s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:GetGenericPortMappingEntry xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1"><NewPortMappingIndex>3</NewPortMappingIndex></u:GetGenericPortMappingEntry></s:Body></s:Envelope>'