Add rust clippy

Author: indy256

.github/workflows/rust.yml

@@ -14,6 +14,8 @@ jobs:
         run: |
           cd rust
           cargo fmt -- --check
+          RUSTFLAGS="-A unused" cargo clippy
+          cargo clippy --tests
       - name: compile
         run: |
           cd rust

rust/Cargo.toml

@@ -5,40 +5,7 @@ version = "0.1.0"
 edition = "2021"
 
 [dev-dependencies]
-rstest="0.21.0"
+rstest="0.22.0"
 
-[[bin]]
-name = "permutations"
-path = "combinatorics/permutations.rs"
-
-[[bin]]
-name = "topological_sort"
-path = "graphs/dfs/topological_sort.rs"
-
-[[bin]]
-name = "dijkstra"
-path = "graphs/shortestpaths/dijkstra.rs"
-
-[[bin]]
-name = "max_bipartite_matching_EV"
-path = "graphs/matchings/max_bipartite_matching_EV.rs"
-
-[[bin]]
-name = "euclid"
-path = "numbertheory/euclid.rs"
-
-[[bin]]
-name = "disjoint_sets"
-path = "structures/disjoint_sets.rs"
-
-[[bin]]
-name = "fenwick_tree"
-path = "structures/fenwick_tree.rs"
-
-[[bin]]
-name = "persistent_tree"
-path = "structures/persistent_tree.rs"
-
-[[bin]]
-name = "binary_search"
-path = "misc/binary_search.rs"
+[lib]
+path = "lib.rs"

rust/combinatorics/mod.rs

@@ -0,0 +1 @@
+pub mod permutations;

rust/combinatorics/permutations.rs

@@ -8,8 +8,8 @@ pub fn next_permutation(p: &mut [usize]) -> Option<()> {
 
 #[cfg(test)]
 mod tests {
-    use crate::next_permutation;
     use rstest::rstest;
+    use crate::combinatorics::permutations::next_permutation;
 
     #[rstest]
     #[case(vec![0], vec![0], None)]

rust/graphs/dfs/mod.rs

@@ -0,0 +1 @@
+pub mod topological_sort;

rust/graphs/dfs/topological_sort.rs

@@ -18,12 +18,12 @@ pub fn topological_sort(graph: &[Vec<usize>]) -> Vec<usize> {
         }
     }
     order.reverse();
-    return order;
+    order
 }
 
 #[cfg(test)]
 mod tests {
-    use crate::topological_sort;
+    use crate::graphs::dfs::topological_sort::topological_sort;
 
     #[test]
     fn basic_test() {

rust/graphs/matchings/max_bipartite_matching_EV.rs renamed to rust/graphs/matchings/max_bipartite_matching_ev.rs

@@ -1,6 +1,3 @@
-#![feature(test)]
-extern crate test;
-
 fn find_path(graph: &[Vec<usize>], u1: usize, matching: &mut [usize], vis: &mut [bool]) -> bool {
     vis[u1] = true;
     for v in &graph[u1] {
@@ -10,7 +7,7 @@ fn find_path(graph: &[Vec<usize>], u1: usize, matching: &mut [usize], vis: &mut
             return true;
         }
     }
-    return false;
+    false
 }
 
 pub fn max_matching(graph: &[Vec<usize>], n2: usize) -> (usize, Vec<usize>) {
@@ -23,13 +20,13 @@ pub fn max_matching(graph: &[Vec<usize>], n2: usize) -> (usize, Vec<usize>) {
             matches += 1;
         }
     }
-    return (matches, matching);
+    (matches, matching)
 }
 
 #[cfg(test)]
 mod tests {
-    use crate::max_matching;
     use test::Bencher;
+    use crate::graphs::matchings::max_bipartite_matching_ev::max_matching;
 
     #[test]
     fn basic_test() {

rust/graphs/matchings/mod.rs

@@ -0,0 +1 @@
+pub mod max_bipartite_matching_ev;

rust/graphs/mod.rs

@@ -0,0 +1,3 @@
+pub mod dfs;
+pub mod matchings;
+pub mod shortestpaths;

rust/graphs/shortestpaths/dijkstra.rs

@@ -22,12 +22,12 @@ pub fn dijkstra_heap(graph: &[Vec<(usize, i32)>], s: usize) -> (Vec<i32>, Vec<us
             }
         }
     }
-    return (prio, pred);
+    (prio, pred)
 }
 
 #[cfg(test)]
 mod tests {
-    use crate::dijkstra_heap;
+    use crate::graphs::shortestpaths::dijkstra::dijkstra_heap;
 
     #[test]
     fn basic_test() {

rust/graphs/shortestpaths/mod.rs

@@ -0,0 +1 @@
+pub mod dijkstra;

rust/lib.rs

@@ -0,0 +1,8 @@
+#![feature(test)]
+extern crate test;
+
+pub mod combinatorics;
+pub mod graphs;
+pub mod misc;
+pub mod numbertheory;
+pub mod structures;

rust/misc/binary_search.rs

@@ -18,8 +18,8 @@ where
 
 #[cfg(test)]
 mod tests {
-    use crate::binary_search_first_true;
     use rstest::rstest;
+    use crate::misc::binary_search::binary_search_first_true;
 
     #[rstest]
     #[case(100, 0)]

rust/misc/mod.rs

@@ -0,0 +1 @@
+pub mod binary_search;

rust/numbertheory/euclid.rs

@@ -1,5 +1,5 @@
 fn gcd(a: i32, b: i32) -> i32 {
-    return if b == 0 { a.abs() } else { gcd(b, a % b) };
+    if b == 0 { a.abs() } else { gcd(b, a % b) }
 }
 
 // returns { gcd(a,b), x, y } such that gcd(a,b) = a*x + b*y
@@ -21,12 +21,12 @@ fn euclid(mut a: i64, mut b: i64) -> [i64; 3] {
         y = _y1;
         a = _b;
     }
-    return if a > 0 { [a, x, y] } else { [-a, -x, -y] };
+    if a > 0 { [a, x, y] } else { [-a, -x, -y] }
 }
 
 #[cfg(test)]
 mod tests {
-    use crate::{euclid, gcd};
+    use crate::numbertheory::euclid::{euclid, gcd};
 
     #[test]
     fn basic_test() {

rust/numbertheory/mod.rs

@@ -0,0 +1 @@
+pub mod euclid;

rust/structures/disjoint_sets.rs

@@ -25,7 +25,7 @@ impl DisjointSets {
 
 #[cfg(test)]
 mod tests {
-    use crate::DisjointSets;
+    use crate::structures::disjoint_sets::DisjointSets;
 
     #[test]
     fn basic_test() {

rust/structures/fenwick_tree.rs

@@ -25,13 +25,13 @@ impl<T: AddAssign + Copy + From<i32>> Fenwick<T> {
             res += self.t[i as usize];
             i = (i & (i + 1)) - 1;
         }
-        return res;
+        res
     }
 }
 
 #[cfg(test)]
 mod tests {
-    use crate::Fenwick;
+    use crate::structures::fenwick_tree::Fenwick;
 
     #[test]
     fn basic_test() {

rust/structures/mod.rs

@@ -0,0 +1,3 @@
+pub mod disjoint_sets;
+pub mod fenwick_tree;
+pub mod persistent_tree;

rust/structures/persistent_tree.rs

@@ -71,7 +71,7 @@ impl PersistentTree {
 
 #[cfg(test)]
 mod tests {
-    use crate::PersistentTree;
+    use crate::structures::persistent_tree::PersistentTree;
 
     #[test]
     fn basic_test() {