Skip to content

Commit c35fd79

Browse files
committed
Resolve PR comments
1. link NodeJS setup to handbook guide 2. add TODO for the app start command 3. remove Licencing section
1 parent d75bf37 commit c35fd79

File tree

1 file changed

+2
-23
lines changed

1 file changed

+2
-23
lines changed

README.template.md

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,12 @@
2121
- [Deployment](#deployment)
2222
- [Releases](#releases)
2323
- [Translations](#translations)
24-
- [Licencing](#licencing)
2524

2625
## Setup
2726

2827
### Prerequisites / Dependencies
2928

30-
You will need to have NodeJS and NPM installed to run this application. It's recommended to use a NodeJS version manager to manage your versions. Required NodeJS versions will typically match LTS (long-term support) versions and you can check which exact version to install by checking `.node-version` file in the repository root.
29+
You will need to have NodeJS and NPM installed to run this application. Use the [handbook guide](https://infinum.com/handbook/frontend/node/managing-node-npm-versions) to set up the correct NodeJS version.
3130

3231
### Installation
3332

@@ -42,7 +41,7 @@ You will need to have NodeJS and NPM installed to run this application. It's rec
4241

4342
### Running the app
4443

45-
To run the app, you can simply run `npm start`. This starts the application in the environment dependent on your environment setup.
44+
To run the app, you can simply run `[TODO:NPM_START_COMMAND]`. This starts the application in the environment dependent on your environment setup.
4645

4746
### Building the app
4847

@@ -125,23 +124,3 @@ Releases are handled through GitHub Releases feature and documentation for it ca
125124
## Translations
126125

127126
The application uses [Polyglot](TODO:PROJECT_POLYGLOT_LINK) for handling translations. More information can be found on the [Translations handling wiki page](TODO:GITHUB_WIKI_PAGE).
128-
129-
## Licencing
130-
131-
The application uses a licence header for all TypeScript files. To help out with setting this up for new files, you can install `licenser` extension.
132-
133-
```
134-
# CMD + P
135-
ext install licenser
136-
137-
```
138-
139-
This extension will add proper license headers to each new file.
140-
141-
You can also add license headers manually:
142-
143-
```
144-
# CMD + SHIFT + P
145-
licenser: Insert license header
146-
147-
```

0 commit comments

Comments
 (0)