Skip to content

Commit 030c3ff

Browse files
authored
fix: native tls tests (#220)
* Sync cargo lock w/ toml config * fix: cert generation, macos openssl3 requires -legacy option * chore: adjust ci for openssl version support
1 parent c918a78 commit 030c3ff

File tree

4 files changed

+22
-12
lines changed

4 files changed

+22
-12
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,14 @@ jobs:
6161
if: ${{ matrix.check == 'fmt' }}
6262
run: make check-fmt
6363
- name: Test
64-
if: ${{ matrix.check == 'test' }}
64+
if: ${{ matrix.check == 'test' && matrix.os != 'macos-latest' }}
6565
timeout-minutes: 15
6666
run: make test-all
67+
- name: Test (macos)
68+
if: ${{ matrix.check == 'test' && matrix.os == 'macos-latest'}}
69+
timeout-minutes: 15
70+
# macos-latest is by default on openssl 1.x
71+
run: make PFX_OPTS="" test-all
6772
- name: cargo audit
6873
if: ${{ matrix.check == 'audit' }}
6974
timeout-minutes: 15

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
RUST_DOCKER_IMAGE=rust:latest
2+
PFX_OPTS ?= "-legacy"
23

34
build-all:
45
cargo build --all-features
56

67
.PHONY: certs
78
certs:
8-
make -C certs generate-certs
9+
make -C certs generate-certs PFX_OPTS=${PFX_OPTS}
910

1011
test-all: certs test-derive
1112
cargo test --all-features

async-test-derive/Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

certs/Makefile

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1+
# -legacy is an openssl3 option for pkcs12 formats whose default
2+
# has shifted
3+
PFX_OPTS ?= "-legacy"
4+
15
clean:
26
rm -rf test-certs
37

48
setup:
59
mkdir -p test-certs
6-
10+
openssl version
711

812
generate-certs: setup generate-ca-crt generate-intermediate-ca-crt generate-server-crt generate-intermediate-chain generate-client-crt generate-pk12-certs
913

@@ -12,7 +16,7 @@ generate-pk12-certs: generate-server-pk12 generate-client-pk12
1216

1317
### CA Generation
1418

15-
generate-ca-key:
19+
generate-ca-key:
1620
openssl genrsa -out test-certs/ca.key 4096
1721

1822
generate-ca-crt: generate-ca-key
@@ -21,7 +25,7 @@ generate-ca-crt: generate-ca-key
2125

2226
### Intermediate CA Generation
2327

24-
generate-intermediate-ca-key:
28+
generate-intermediate-ca-key:
2529
openssl genrsa -out test-certs/intermediate-ca.key 4096
2630

2731
generate-intermediate-ca-csr: generate-intermediate-ca-key
@@ -56,19 +60,19 @@ generate-server-csr: generate-server-key
5660

5761
### Intermediate Chain Server
5862

59-
generate-intermediate-server-key:
63+
generate-intermediate-server-key:
6064
openssl genrsa -out test-certs/intermediate-server.key 4096
6165

6266

6367
generate-intermediate-server-csr: generate-intermediate-server-key
6468
openssl req -new -key test-certs/intermediate-server.key \
6569
-out test-certs/intermediate-server.csr \
66-
-config cert.conf
70+
-config cert.conf
6771

6872
# generate anonymous pk12
6973
.PHONY: generate-server-pk12
70-
generate-server-pk12:
71-
openssl pkcs12 -export -out test-certs/server.pfx -inkey test-certs/server.key -in test-certs/server.crt -certfile test-certs/ca.crt -passout pass:test
74+
generate-server-pk12:
75+
openssl pkcs12 -export -out test-certs/server.pfx ${PFX_OPTS} -inkey test-certs/server.key -in test-certs/server.crt -certfile test-certs/ca.crt -passout pass:test
7276

7377

7478

@@ -131,7 +135,7 @@ generate-client-crt: generate-client-csr
131135
-extfile openssl.cnf
132136

133137
generate-client-pk12:
134-
openssl pkcs12 -export -out test-certs/client.pfx -inkey test-certs/client.key -in test-certs/client.crt -certfile test-certs/ca.crt -passout pass:test
138+
openssl pkcs12 -export -out test-certs/client.pfx ${PFX_OPTS} -inkey test-certs/client.key -in test-certs/client.crt -certfile test-certs/ca.crt -passout pass:test
135139

136140

137141
# for non mac
@@ -151,7 +155,7 @@ start-nginx:
151155
nginx -c $(MAKE_DIR)/nginx.conf
152156

153157
start-intermediate-nginx:
154-
nginx -c $(MAKE_DIR)/intermediate-nginx.conf
158+
nginx -c $(MAKE_DIR)/intermediate-nginx.conf
155159

156160
stop-nginx:
157161
nginx -s quit

0 commit comments

Comments
 (0)