Fix bug with report creation

Author: maricaantonacci

app/deployments/routes.py

@@ -91,51 +91,14 @@ def showdeployments():
     return render_template("deployments.html", deployments=deployments)
 
 
-def update_deployments():
-    issuer = app.settings.iam_url
-    if not issuer.endswith("/"):
-        issuer += "/"
-
-    subject = session["userid"]
-
-    # retrieve deployments from orchestrator
-    access_token = iam.token["access_token"]
-    deployments_from_orchestrator = []
-    try:
-        deployments_from_orchestrator = app.orchestrator.get_deployments(
-            access_token, created_by="{}@{}".format(subject, issuer)
-        )
-    except Exception as e:
-        flash("Error retrieving deployment list: \n" + str(e), "warning")
-
-    update_deployments_status(deployments_from_orchestrator, subject)
-
-
-def update_deployments_status(deployments_from_orchestrator, subject):
-    if not deployments_from_orchestrator:
-        return
-
-    iids = dbhelpers.updatedeploymentsstatus(deployments_from_orchestrator, subject)["iids"]
-
-    # retrieve deployments from DB
-    deployments = dbhelpers.cvdeployments(dbhelpers.get_user_deployments(subject))
-    for dep in deployments:
-        newremote = dep.remote
-        if dep.uuid not in iids:
-            if dep.remote == 1:
-                newremote = 0
-        else:
-            if dep.remote == 0:
-                newremote = 1
-        if dep.remote != newremote:
-            dbhelpers.update_deployment(dep.uuid, dict(remote=newremote))
-
-
 @deployments_bp.route("/overview")
 @auth.authorized_with_valid_token
 def showdeploymentsoverview():
     # refresh deployment list
-    update_deployments()
+    try:
+        dbhelpers.update_deployments(session["userid"])
+    except Exception as e:
+        flash("Error retrieving deployment list: \n" + str(e), "warning")
 
     deps = dbhelpers.get_user_deployments(session["userid"])
     # Initialize dictionaries for status, projects, and providers
@@ -239,7 +202,8 @@ def preprocess_outputs(outputs, stoutputs, inputs):
 @auth.authorized_with_valid_token
 def depoutput(depid=None):
     """
-    A function to render the details of a deployment, including inputs, outputs, and structured outputs.
+    A function to render the details of a deployment, including inputs, outputs, 
+    and structured outputs.
     Parameters:
     - depid: str, the ID of the deployment
     Returns:

app/home/routes.py

@@ -357,6 +357,7 @@ def home():
 
 
 @home_bp.route("/portfolio")
+@auth.authorized_with_valid_token
 def portfolio():
     """
     A route function for the "/portfolio" endpoint.
@@ -366,6 +367,11 @@ def portfolio():
     and renders the portfolio template with the retrieved data.
     If the user is not logged in, it redirects to the login page.
     """
+    try:
+        dbhelpers.update_deployments(session["userid"])
+    except Exception as e:
+        flash("Error retrieving deployment list: \n" + str(e), "warning")
+
     deps = dbhelpers.get_user_deployments(session["userid"])
     statuses = {}
     for dep in deps:

app/lib/dbhelpers.py

@@ -96,7 +96,6 @@ def updatedeploymentsstatus(deployments, userid):
     result = {}
     deps = []
     iids = []
-    # uuid = ''
 
     # update deployments status in database
     for dep_json in deployments:
@@ -268,6 +267,42 @@ def cvdeployment(d):
     return deployment
 
 
+def update_deployments(subject):
+    issuer = app.settings.iam_url
+    if not issuer.endswith("/"):
+        issuer += "/"
+
+    # retrieve deployments from orchestrator
+    access_token = iam.token["access_token"]
+    deployments_from_orchestrator = []
+
+    deployments_from_orchestrator = app.orchestrator.get_deployments(
+        access_token, created_by="{}@{}".format(subject, issuer)
+    )
+
+    update_deployments_status(deployments_from_orchestrator, subject)
+
+
+def update_deployments_status(deployments_from_orchestrator, subject):
+    if not deployments_from_orchestrator:
+        return
+
+    iids = updatedeploymentsstatus(deployments_from_orchestrator, subject)["iids"]
+
+    # retrieve deployments from DB
+    deployments = cvdeployments(get_user_deployments(subject))
+    for dep in deployments:
+        newremote = dep.remote
+        if dep.uuid not in iids:
+            if dep.remote == 1:
+                newremote = 0
+        else:
+            if dep.remote == 0:
+                newremote = 1
+        if dep.remote != newremote:
+            update_deployment(dep.uuid, dict(remote=newremote))
+
+
 def get_services(visibility, groups=[]):
     services = []
     if visibility == "public":