fix: introduce AcknowledgementStatus instead

Author: Farhad-Shabani

crates/ibc/src/applications/interchain_accounts/controller/callback.rs

@@ -6,7 +6,7 @@ use crate::applications::interchain_accounts::metadata::Metadata;
 use crate::applications::interchain_accounts::port::default_host_port_id;
 use crate::applications::interchain_accounts::port::verify_controller_port_id_prefix;
 use crate::core::ics04_channel::acknowledgement::Acknowledgement;
-use crate::core::ics04_channel::acknowledgement::AcknowledgementResult;
+use crate::core::ics04_channel::acknowledgement::AcknowledgementStatus;
 use crate::core::ics04_channel::channel::Counterparty;
 use crate::core::ics04_channel::channel::Order;
 use crate::core::ics04_channel::channel::State;
@@ -265,7 +265,10 @@ pub fn on_recv_packet_execute(
 ) -> (ModuleExtras, Acknowledgement) {
     (
         ModuleExtras::empty(),
-        AcknowledgementResult::success("").into(), // TODO: return error
+        AcknowledgementStatus::error(
+            InterchainAccountError::not_allowed("packet cannot be received").into(),
+        )
+        .into(),
     )
 }
 

crates/ibc/src/applications/interchain_accounts/error.rs

@@ -1,3 +1,4 @@
+use crate::core::ics04_channel::acknowledgement::StatusValue;
 use crate::core::ics04_channel::error::ChannelError;
 use crate::core::ContextError;
 use crate::prelude::*;
@@ -116,6 +117,12 @@ impl From<ChannelError> for InterchainAccountError {
     }
 }
 
+impl From<InterchainAccountError> for StatusValue {
+    fn from(err: InterchainAccountError) -> Self {
+        StatusValue::new(err.to_string()).expect("error message cannot be empty")
+    }
+}
+
 #[derive(Clone, Debug)]
 pub enum Code {
     /// cannot be empty!

crates/ibc/src/applications/interchain_accounts/host/callback.rs

@@ -2,13 +2,14 @@
 
 use alloc::string::ToString;
 
+use crate::applications::interchain_accounts::ack_success;
 use crate::applications::interchain_accounts::context::InterchainAccountExecutionContext;
 use crate::applications::interchain_accounts::context::InterchainAccountValidationContext;
 use crate::applications::interchain_accounts::error::InterchainAccountError;
 use crate::applications::interchain_accounts::metadata::Metadata;
 use crate::applications::interchain_accounts::port::default_host_port_id;
 use crate::core::ics04_channel::acknowledgement::Acknowledgement;
-use crate::core::ics04_channel::acknowledgement::AcknowledgementResult;
+use crate::core::ics04_channel::acknowledgement::AcknowledgementStatus;
 use crate::core::ics04_channel::channel::Counterparty;
 use crate::core::ics04_channel::channel::Order;
 use crate::core::ics04_channel::packet::Packet;
@@ -280,31 +281,31 @@ pub fn on_recv_packet_execute(
         Err(e) => {
             return (
                 ModuleExtras::empty(),
-                AcknowledgementResult::from_error(e).into(),
+                AcknowledgementStatus::error(e.into()).into(),
             )
         }
     };
 
     if !params.host_enabled {
         return (
             ModuleExtras::empty(),
-            AcknowledgementResult::from_error(InterchainAccountError::not_supported(
-                "host chain is not enabled.",
-            ))
+            AcknowledgementStatus::error(
+                InterchainAccountError::not_supported("host chain is not enabled.").into(),
+            )
             .into(),
         );
     }
 
     if let Err(e) = on_recv_packet(ctx_b, packet) {
         return (
             ModuleExtras::empty(),
-            AcknowledgementResult::from_error(e).into(),
+            AcknowledgementStatus::error(e.into()).into(),
         );
     }
 
     (
         ModuleExtras::empty(),
-        AcknowledgementResult::success("").into(), //TODO: what's the result string?
+        AcknowledgementStatus::success(ack_success()).into(),
     )
 }
 

crates/ibc/src/applications/interchain_accounts/mod.rs

@@ -25,3 +25,14 @@ pub const MODULE_ID_STR: &str = "interchainaccounts";
 
 /// ICS27 application current version.
 pub const VERSION: &str = "ics27-1";
+
+/// The successful string used for creating an acknowledgement status,
+/// equivalent to `base64::encode(0x01)`.
+pub const ACK_SUCCESS: &str = "AQ=="; //TODO: what's the result string?
+
+use crate::core::ics04_channel::acknowledgement::StatusValue;
+
+/// Returns a successful acknowledgement status for the interchain accounts application.
+pub fn ack_success() -> StatusValue {
+    StatusValue::new(ACK_SUCCESS).expect("ack status value is never supposed to be empty")
+}

crates/ibc/src/applications/mod.rs

@@ -3,5 +3,5 @@
 #[cfg(feature = "serde")]
 pub mod transfer;
 
-#[cfg(feature = "interchain-accounts")]
+// #[cfg(feature = "interchain-accounts")]
 pub mod interchain_accounts;