Skip to content

Commit c62de65

Browse files
Copilotrnbguy
andauthored
fix: incorrect ID usage in IBC connection and packet handlers (#474)
* Initial plan * Fix ConnOpenAck typo: use conn_id_on_a instead of conn_id_on_b Co-authored-by: rnbguy <3789449+rnbguy@users.noreply.github.com> * fix: use correct port/channel IDs in ack_path verification Co-authored-by: rnbguy <3789449+rnbguy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rnbguy <3789449+rnbguy@users.noreply.github.com>
1 parent f85d4e1 commit c62de65

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

cairo-contracts/packages/core/src/channel/components/handler.cairo

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1053,8 +1053,8 @@ pub mod ChannelHandlerComponent {
10531053

10541054
let paths = ack_path(
10551055
connection_end.counterparty.prefix,
1056-
msg.packet.port_id_on_a,
1057-
msg.packet.chan_id_on_a,
1056+
msg.packet.port_id_on_b,
1057+
msg.packet.chan_id_on_b,
10581058
msg.packet.seq_on_a,
10591059
);
10601060

cairo-contracts/packages/core/src/connection/components/handler.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ pub mod ConnectionHandlerComponent {
251251
let expected_conn_end_on_b = ConnectionEndTrait::try_open(
252252
conn_end_on_a.counterparty.client_id.clone(),
253253
conn_end_on_a.client_id.clone(),
254-
msg.conn_id_on_b.clone(),
254+
msg.conn_id_on_a.clone(),
255255
conn_end_on_a.counterparty.prefix.clone(),
256256
conn_end_on_a.delay_period,
257257
);

0 commit comments

Comments
 (0)