chore(code/test): Move unit tests from malachite-test into their respective crates (#597)

* Disable `unused_crate_dependencies` lint as it is utterly broken

See rust-lang/rust#95513

* Move driver tests into the `driver` crate

* Move vote keeper tests into the `vote` crate

* Move full proposal keeper tests into the `consensus` crate

---------

Co-authored-by: Anca Zamfir <[email protected]>

Author: romac

code/Cargo.lock

@@ -24,6 +24,7 @@ members = [
   # Test
   "crates/test",
   "crates/test/mbt",
+  "crates/driver/test-utils",
 
   # Starknet
   "crates/starknet/*",
@@ -50,7 +51,7 @@ inherits = "release"
 debug = true
 
 [workspace.lints.rust]
-unused_crate_dependencies = "warn"
+# None for now
 
 [workspace.dependencies]
 malachite-actors           = { version = "0.1.0", path = "crates/actors" }
@@ -67,11 +68,14 @@ malachite-metrics          = { version = "0.1.0", path = "crates/metrics" }
 malachite-node             = { version = "0.1.0", path = "crates/node" }
 malachite-proto            = { version = "0.1.0", path = "crates/proto" }
 malachite-round            = { version = "0.1.0", path = "crates/round" }
-malachite-test             = { version = "0.1.0", path = "crates/test" }
-malachite-test-mbt         = { version = "0.1.0", path = "crates/test/mbt" }
 malachite-vote             = { version = "0.1.0", path = "crates/vote" }
 malachite-signing-ed25519  = { version = "0.1.0", path = "crates/signing-ed25519" }
 
+# Test
+malachite-test              = { version = "0.1.0", path = "crates/test" }
+malachite-test-mbt          = { version = "0.1.0", path = "crates/test/mbt" }
+malachite-driver-test-utils = { version = "0.1.0", path = "crates/driver/test-utils" }
+
 # Starknet
 malachite-starknet-host      = { version = "0.1.0", path = "crates/starknet/host" }
 malachite-starknet-app       = { version = "0.1.0", path = "crates/starknet/app" }

code/Cargo.toml

@@ -2,7 +2,7 @@
 
 #![no_std]
 #![forbid(unsafe_code)]
-#![deny(unused_crate_dependencies, trivial_casts, trivial_numeric_casts)]
+#![deny(trivial_casts, trivial_numeric_casts)]
 #![warn(
     missing_docs,
     rustdoc::broken_intra_doc_links,

code/crates/common/src/lib.rs

@@ -27,3 +27,6 @@ tracing         = { workspace = true }
 
 [lints]
 workspace = true
+
+[dev-dependencies]
+malachite-test = { workspace = true }

code/crates/consensus/Cargo.toml

@@ -1,6 +1,5 @@
-use malachite_actors::host::ProposedValue;
 use malachite_common::{Context, Round, SignedProposal, Validity};
-use malachite_consensus::{FullProposal, FullProposalKeeper, Input};
+use malachite_consensus::{FullProposal, FullProposalKeeper, Input, ProposedValue};
 use malachite_test::utils::validators::make_validators;
 use malachite_test::{Address, Proposal, Value};
 use malachite_test::{Height, TestContext};

code/crates/test/tests/full_proposal_keeper.rs renamed to code/crates/consensus/tests/full_proposal.rs

@@ -17,9 +17,13 @@ debug = ["std", "malachite-round/debug"]
 workspace = true
 
 [dependencies]
-malachite-common = { version = "0.1.0", path = "../common" }
-malachite-round  = { version = "0.1.0", path = "../round" }
-malachite-vote   = { version = "0.1.0", path = "../vote" }
+malachite-common = { workspace = true }
+malachite-round  = { workspace = true }
+malachite-vote   = { workspace = true }
 
 derive-where = { workspace = true }
 thiserror    = { workspace = true, default-features = false }
+
+[dev-dependencies]
+malachite-test              = { workspace = true }
+malachite-driver-test-utils = { workspace = true }

code/crates/driver/Cargo.toml

@@ -1,7 +1,7 @@
 //! Driver for the state machine of the Malachite consensus engine
 
 #![forbid(unsafe_code)]
-#![deny(unused_crate_dependencies, trivial_casts, trivial_numeric_casts)]
+#![deny(trivial_casts, trivial_numeric_casts)]
 #![warn(
     missing_docs,
     rustdoc::broken_intra_doc_links,

code/crates/driver/src/lib.rs

@@ -0,0 +1,18 @@
+[package]
+name        = "malachite-driver-test-utils"
+description = "Test utilities for the `malachite-driver`"
+publish     = false
+
+version.workspace      = true
+edition.workspace      = true
+repository.workspace   = true
+license.workspace      = true
+rust-version.workspace = true
+
+
+[dependencies]
+malachite-common = { workspace = true }
+malachite-round  = { workspace = true }
+malachite-vote   = { workspace = true }
+malachite-test   = { workspace = true }
+malachite-driver = { workspace = true }

code/crates/driver/test-utils/Cargo.toml

@@ -1,8 +1,7 @@
 use malachite_common::{NilOrVal, Round, SignedProposal, SignedVote, Timeout, Validity};
 use malachite_driver::{Input, Output};
 use malachite_round::state::{RoundValue, State, Step};
-
-use crate::{Address, Height, Proposal, Signature, TestContext, Value, Vote};
+use malachite_test::{Address, Height, Proposal, Signature, TestContext, Value, Vote};
 
 pub fn new_round_input(round: Round, proposer: Address) -> Input<TestContext> {
     Input::NewRound(Height::new(1), round, proposer)

code/crates/test/src/utils/driver.rs renamed to code/crates/driver/test-utils/src/lib.rs

@@ -2,7 +2,7 @@ use malachite_common::{Round, Validity};
 use malachite_driver::{Driver, Input, Output};
 use malachite_round::state::State;
 
-use malachite_test::utils::driver::*;
+use malachite_driver_test_utils::*;
 use malachite_test::utils::validators::make_validators;
 use malachite_test::{Height, Proposal, TestContext, ValidatorSet, Value};
 

code/crates/test/tests/driver.rs renamed to code/crates/driver/tests/basic.rs

@@ -1,5 +1,3 @@
-#![allow(unused_crate_dependencies)]
-
 use std::{time::Duration, vec};
 
 use malachite_discovery_test::{Expected, Test, TestNode};

code/crates/test/tests/driver_extra.rs renamed to code/crates/driver/tests/extra.rs

@@ -1,7 +1,7 @@
 //! Per-round consensus state machine
 
 #![forbid(unsafe_code)]
-#![deny(unused_crate_dependencies, trivial_casts, trivial_numeric_casts)]
+#![deny(trivial_casts, trivial_numeric_casts)]
 #![warn(
     missing_docs,
     rustdoc::broken_intra_doc_links,

code/crates/gossip-consensus/test/tests/discovery.rs

@@ -1,5 +1,3 @@
-#![allow(unused_crate_dependencies)]
-
 use std::time::Duration;
 
 use malachite_starknet_test::{Test, TestNode, TestParams};

code/crates/round/src/lib.rs

@@ -1,5 +1,3 @@
-#![allow(unused_crate_dependencies)]
-
 use std::time::Duration;
 
 use malachite_config::ValuePayload;

code/crates/starknet/test/tests/blocksync.rs

@@ -1,5 +1,3 @@
-#![allow(unused_crate_dependencies)]
-
 use std::time::Duration;
 
 use bytesize::ByteSize;

code/crates/starknet/test/tests/n2f0_consensus_mode.rs

@@ -1,5 +1,3 @@
-#![allow(unused_crate_dependencies)]
-
 use std::time::Duration;
 
 use malachite_starknet_test::{Test, TestNode};

code/crates/starknet/test/tests/n2f0_pubsub_protocol.rs

@@ -1,5 +1,3 @@
-#![allow(unused_crate_dependencies)]
-
 use std::time::Duration;
 
 use malachite_starknet_test::{Test, TestNode};

code/crates/starknet/test/tests/n3f0.rs

@@ -10,19 +10,11 @@ license.workspace      = true
 rust-version.workspace = true
 
 [dependencies]
-malachite-actors          = { workspace = true }
 malachite-common          = { workspace = true }
-malachite-consensus       = { workspace = true }
-malachite-driver          = { workspace = true }
-malachite-config          = { workspace = true }
-malachite-round           = { workspace = true }
-malachite-vote            = { workspace = true }
 malachite-proto           = { workspace = true }
 malachite-signing-ed25519 = { workspace = true, features = ["rand", "serde"] }
 
-async-trait        = { workspace = true }
 base64             = { workspace = true }
-bytesize           = { workspace = true }
 bytes              = { workspace = true }
 ed25519-consensus  = { workspace = true }
 hex                = { workspace = true }
@@ -32,9 +24,6 @@ rand               = { workspace = true }
 serde              = { workspace = true, features = ["derive"] }
 sha3               = { workspace = true }
 signature          = { workspace = true }
-tokio              = { workspace = true }
-tracing            = { workspace = true }
-tracing-subscriber = { workspace = true, features = ["fmt", "env-filter"] }
 
 [build-dependencies]
 prost-build = { workspace = true }

code/crates/starknet/test/tests/n3f1.rs

@@ -1,2 +1 @@
-pub mod driver;
 pub mod validators;