Merge pull request #94 from jeroenhabets/ebs-volume-tags-79

Name and tag cluster worker EBS volumes

Author: tobyclemson

CHANGELOG.md

@@ -14,7 +14,10 @@ IMPROVEMENTS:
   users of this module to require that IMDSv2 be used by containers in the 
   cluster. By default, IMDSv2 is not required in this version of the module but
   a future major release of the module may enforce IMDSv2 usage.
-
+* The EBS volumes attached to container instances are now tagged with
+  `Component`, `DeploymentIdentifier`, `Name` and `ClusterName` tags by default,
+  as well as with any tags passed in the `tags` var when provided (resolves 
+  #94).
 
 ## 6.0.0 (February 22th 2023)
 

asg.tf

@@ -62,6 +62,17 @@ resource "aws_launch_template" "cluster" {
     enabled = var.enable_detailed_monitoring
   }
 
+  tag_specifications {
+    resource_type = "volume"
+    tags = merge(
+      local.tags,
+      {
+        Name        = "cluster-worker-${var.component}-${var.deployment_identifier}-${var.cluster_name}"
+        ClusterName = var.cluster_name
+      }
+    )
+  }
+
   depends_on = [
     null_resource.iam_wait
   ]

spec/unit/launch_template_spec.rb

@@ -9,6 +9,12 @@
   let(:dep_id) do
     var(role: :root, name: 'deployment_identifier')
   end
+  let(:cluster_name) do
+    'default'
+  end
+  let(:tags) do
+    var(role: :root, name: 'tags')
+  end
   let(:region) do
     var(role: :root, name: 'region')
   end
@@ -161,6 +167,26 @@
     end
   end
 
+  describe 'tag specifications' do
+    it 'sets default and provided tags on volumes' do
+      expect(@plan)
+        .to(include_resource_creation(type: 'aws_launch_template')
+              .with_attribute_value(
+                [:tag_specifications, 0],
+                {
+                  resource_type: 'volume',
+                  tags: {
+                    'Component' => component,
+                    'DeploymentIdentifier' => dep_id,
+                    'Name' =>
+                      "cluster-worker-#{component}-#{dep_id}-#{cluster_name}",
+                    'ClusterName' => cluster_name
+                  }.merge(tags)
+                }
+              ))
+    end
+  end
+
   context 'when root block device path is specified' do
     device_path = '/custom/path'