Add Missing Optional Annotation for Port (#288)

* add optional label

Signed-off-by: Stephen Hwang <[email protected]>

* add migration

Signed-off-by: Stephen Hwang <[email protected]>

* fix merge conflictsg

Signed-off-by: Stephen Hwang <[email protected]>

* fix lint

Signed-off-by: Stephen Hwang <[email protected]>

---------

Signed-off-by: Stephen Hwang <[email protected]>

Author: sthwang-metal

cmd/serve.go

@@ -50,7 +50,7 @@ var (
 var serveCmd = &cobra.Command{
 	Use:   "serve",
 	Short: "Start the load balancer Graph API",
-	RunE: func(cmd *cobra.Command, args []string) error {
+	RunE: func(cmd *cobra.Command, _ []string) error {
 		if pidFileName != "" {
 			if err := writePidFile(pidFileName); err != nil {
 				logger.Error("failed to write pid file", zap.Error(err))

db/migrations/20240214095509_change_port_name_optional.sql

@@ -0,0 +1,7 @@
+-- +goose Up
+-- modify "ports" table
+ALTER TABLE "ports" ALTER COLUMN "name" DROP NOT NULL;
+
+-- +goose Down
+-- reverse: modify "ports" table
+ALTER TABLE "ports" ALTER COLUMN "name" SET NOT NULL;

db/migrations/atlas.sum

@@ -1,7 +1,8 @@
-h1:0KtiTooJCnoUsSF1CYnlRKEVEQFmH2Fj55S/41WmJr8=
+h1:MujJgh8ifO4DK4QeukfFWRsa5OFI9Q0agyQwNlkI/3Q=
 20230503185445_initial-migration.sql h1:4pqNp2MDBBRdGxU/H5mmZui9oi1SyjIiMVGatajrBeY=
 20230615194819_drop_tenant_add_owner.sql h1:KGCsItU0NYhxYEkhZOaMQjfIrBMnek5rxC6D/LhnyCk=
 20230629085916_drop_status_and_annotations.sql h1:kvDMoaMEjyoj/aRi6rw4XvCLxGH09vGGLbL0/p5tpPo=
 20231017005257_add_origin_weight.sql h1:NuorUbcydDqcyPK8wgwlkQxaH+zGWfVtJW9UPL1Vn+E=
 20240207205734_audit-fields.sql h1:cplFCBB7laCP5Y+UAoxIfITMo56Hoc5XIVvgcfGL9o0=
 20240208121103_softdelete.sql h1:rt3nHn/1KzxSAbJZ33fQJZi5emLk7Q2PCRcfxWUeveY=
+20240214095509_change_port_name_optional.sql h1:ArlIsVK4Tgi6AW6NiRMbAqU43+5KFqDkaa+YmxSoBkE=

internal/ent/generated/gql_mutation_input.go

@@ -54,7 +54,8 @@ func (Port) Fields() []ent.Field {
 		field.String("name").
 			Annotations(
 				entgql.OrderField("name"),
-			),
+			).
+			Optional(),
 		field.String("load_balancer_id").
 			GoType(gidx.PrefixedID("")).
 			Immutable().

internal/ent/generated/gql_where_input.go

@@ -397,7 +397,7 @@ func TestFullLoadBalancerLifecycle(t *testing.T) {
 	assert.Equal(t, ownerID, createdLB.Owner.ID)
 
 	createdPortResp, err := graphTestClient().LoadBalancerPortCreate(ctx, graphclient.CreateLoadBalancerPortInput{
-		Name:           gofakeit.DomainName(),
+		Name:           newString(gofakeit.DomainName()),
 		Number:         8080,
 		LoadBalancerID: createdLB.ID,
 	})