Skip to content

Commit d85a9ac

Browse files
(DEL-2899) Make Port Name Optional (#287)
* make port name optional Signed-off-by: Stephen Hwang <[email protected]> * fix unit tests Signed-off-by: Stephen Hwang <[email protected]> --------- Signed-off-by: Stephen Hwang <[email protected]>
1 parent 40a661c commit d85a9ac

File tree

10 files changed

+25
-49
lines changed

10 files changed

+25
-49
lines changed

internal/ent/generated/port/port.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/ent/generated/port_create.go

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/ent/generated/port_update.go

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/ent/generated/runtime.go

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/ent/schema/port.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ func (Port) Fields() []ent.Field {
4848
entgql.OrderField("number"),
4949
),
5050
field.String("name").
51-
NotEmpty().
5251
Annotations(
5352
entgql.OrderField("name"),
5453
),

internal/graphapi/loadbalancer.resolvers.go

Lines changed: 4 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/graphapi/origin.resolvers.go

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/graphapi/pool.resolvers.go

Lines changed: 4 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/graphapi/port.resolvers.go

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/graphapi/port_test.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,16 @@ func TestCreate_LoadbalancerPort(t *testing.T) {
5353
},
5454
},
5555
{
56-
TestName: "fails to create loadbalancer port with empty name",
56+
TestName: "succeeds in creating loadbalancer port with empty name",
5757
Input: graphclient.CreateLoadBalancerPortInput{
5858
Name: "",
5959
LoadBalancerID: lb.ID,
60-
Number: 22,
60+
Number: 23,
61+
},
62+
Expected: &graphclient.LoadBalancerPort{
63+
Name: "",
64+
Number: 23,
6165
},
62-
errorMsg: "value is less than the required length",
6366
},
6467
{
6568
TestName: "fails to create loadbalancer port with empty loadbalancer id",
@@ -220,12 +223,15 @@ func TestUpdate_LoadbalancerPort(t *testing.T) {
220223
},
221224
},
222225
{
223-
TestName: "fails to update loadbalancer port name to empty",
226+
TestName: "succeeds in updating loadbalancer port name to empty",
224227
ID: port.ID,
225228
Input: graphclient.UpdateLoadBalancerPortInput{
226229
Name: newString(""),
227230
},
228-
errorMsg: "value is less than the required length",
231+
Expected: &graphclient.LoadBalancerPort{
232+
Name: "",
233+
Number: 22,
234+
},
229235
},
230236
{
231237
TestName: "fails to update loadbalancer port number < min",

0 commit comments

Comments
 (0)