fix test

Author: beer-1

x/tokenfactory/types/msgs.go

@@ -161,16 +161,15 @@ func NewMsgChangeAdmin(sender, denom, newAdmin string) *MsgChangeAdmin {
 }
 
 func (m MsgChangeAdmin) Validate(accAddrCodec address.Codec) error {
-	if addr, err := accAddrCodec.StringToBytes(m.Sender); err != nil {
+	if _, err := accAddrCodec.StringToBytes(m.Sender); err != nil {
 		return err
-	} else if len(addr) == 0 {
-		return ErrEmptySender
 	}
 
-	if addr, err := accAddrCodec.StringToBytes(m.NewAdmin); err != nil {
-		return err
-	} else if len(addr) == 0 {
-		return ErrEmptyNewAdmin
+	// allow empty address
+	if len(m.NewAdmin) > 0 {
+		if _, err := accAddrCodec.StringToBytes(m.NewAdmin); err != nil {
+			return err
+		}
 	}
 
 	if _, _, err := DeconstructDenom(accAddrCodec, m.Denom); err != nil {

x/tokenfactory/types/msgs_test.go

@@ -374,39 +374,39 @@ func TestMsgChangeAdmin(t *testing.T) {
 
 	tests := []struct {
 		name       string
-		msg        func() *types.MsgChangeAdmin
+		msg        func() types.MsgChangeAdmin
 		expectPass bool
 	}{
 		{
 			name: "proper msg",
-			msg: func() *types.MsgChangeAdmin {
-				msg := baseMsg
+			msg: func() types.MsgChangeAdmin {
+				msg := *baseMsg
 				return msg
 			},
 			expectPass: true,
 		},
 		{
 			name: "empty sender",
-			msg: func() *types.MsgChangeAdmin {
-				msg := baseMsg
+			msg: func() types.MsgChangeAdmin {
+				msg := *baseMsg
 				msg.Sender = ""
 				return msg
 			},
 			expectPass: false,
 		},
 		{
 			name: "empty newAdmin",
-			msg: func() *types.MsgChangeAdmin {
-				msg := baseMsg
+			msg: func() types.MsgChangeAdmin {
+				msg := *baseMsg
 				msg.NewAdmin = ""
 				return msg
 			},
-			expectPass: false,
+			expectPass: true,
 		},
 		{
 			name: "invalid denom",
-			msg: func() *types.MsgChangeAdmin {
-				msg := baseMsg
+			msg: func() types.MsgChangeAdmin {
+				msg := *baseMsg
 				msg.Denom = "bitcoin"
 				return msg
 			},