fix: check number of argument at init_module verification (#41)

* check number of argument in init_module function

* allow empty argument init_module

Author: beer-1

crates/compiler/src/extended_checks.rs

@@ -93,6 +93,12 @@ impl<'a> ExtendedChecker<'a> {
                     );
                 }
             }
+            if fun.get_parameters().len() > 1 {
+                self.env.error(
+                    &fun.get_loc(),
+                    "`init_module` function can only take at most one parameter",
+                );
+            }
             if fun.get_return_count() > 0 {
                 self.env.error(
                     &fun.get_loc(),

crates/vm/src/move_vm.rs

@@ -581,10 +581,14 @@ impl MoveVM {
             // with the general verify_module above.
             if init_function.is_ok() {
                 if verify_module_init_function(module).is_ok() {
-                    let args: Vec<Vec<u8>> = senders
-                        .iter()
-                        .map(|s| MoveValue::Signer(*s).simple_serialize().unwrap())
-                        .collect();
+                    let args: Vec<Vec<u8>> = if init_function.unwrap().parameters.is_empty() {
+                        vec![]
+                    } else {
+                        senders
+                            .iter()
+                            .map(|s| MoveValue::Signer(*s).simple_serialize().unwrap())
+                            .collect()
+                    };
 
                     // first execution does not execute `charge_call`, so need to record call here
                     gas_meter.record_call(&module.self_id());

crates/vm/src/verifier/module_init.rs

@@ -31,15 +31,22 @@ pub(crate) fn verify_module_init_function(module: &CompiledModule) -> PartialVMR
     }
 
     let fhandle = module.function_handle_at(fdef.function);
-    let parameters = module.signature_at(fhandle.parameters);
 
+    // check init_module has no return
     let return_ = module.signature_at(fhandle.return_);
-
     if !return_.0.is_empty() {
         return Err(PartialVMError::new(StatusCode::VERIFICATION_ERROR)
             .with_message("module_init_function should not return".to_string()));
     }
 
+    // check init_module has exactly one argument
+    let parameters = module.signature_at(fhandle.parameters);
+    if parameters.0.len() > 1 {
+        return Err(PartialVMError::new(StatusCode::VERIFICATION_ERROR)
+            .with_message("module_init_function can only take at most one parameter".to_string()));
+    }
+
+    // check init_module has only signer arguments
     let non_signer_tokens = parameters
         .0
         .iter()