change syncing query logic (#64)

sh-cha · coderabbitai[bot] · web-flow · commit 592baed416db · 2025-01-22T16:03:33.000+09:00
* change syncing query logic

* Apply suggestions from code review

Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;

---------

Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/challenger/challenger.go b/challenger/challenger.go
@@ -231,7 +231,9 @@ func (c *Challenger) RegisterQuerier() {
 		if err != nil {
 			return err
 		}
-		return ctx.JSON(*status.Host.Node.Syncing && *status.Child.Node.Syncing)
+		hostSync := status.Host.Node.Syncing != nil && *status.Host.Node.Syncing
+		childSync := status.Child.Node.Syncing != nil && *status.Child.Node.Syncing
+		return ctx.JSON(hostSync || childSync)
 	})
 }
 
diff --git a/executor/querier.go b/executor/querier.go
@@ -74,6 +74,6 @@ func (ex *Executor) RegisterQuerier() {
 		hostSync := status.Host.Node.Syncing != nil && *status.Host.Node.Syncing
 		childSync := status.Child.Node.Syncing != nil && *status.Child.Node.Syncing
 		batchSync := status.BatchSubmitter.Node.Syncing != nil && *status.BatchSubmitter.Node.Syncing
-		return c.JSON(hostSync && childSync && batchSync)
+		return c.JSON(hostSync || childSync || batchSync)
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,9 @@ func (c *Challenger) RegisterQuerier() {`
`231`	`231`	`if err != nil {`
`232`	`232`	`return err`
`233`	`233`	`}`
`234`		`- return ctx.JSON(status.Host.Node.Syncing && status.Child.Node.Syncing)`
	`234`	`+ hostSync := status.Host.Node.Syncing != nil && *status.Host.Node.Syncing`
	`235`	`+ childSync := status.Child.Node.Syncing != nil && *status.Child.Node.Syncing`
	`236`	`+ return ctx.JSON(hostSync \|\| childSync)`
`235`	`237`	`})`
`236`	`238`	`}`
`237`	`239`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,6 @@ func (ex *Executor) RegisterQuerier() {`
`74`	`74`	`hostSync := status.Host.Node.Syncing != nil && *status.Host.Node.Syncing`
`75`	`75`	`childSync := status.Child.Node.Syncing != nil && *status.Child.Node.Syncing`
`76`	`76`	`batchSync := status.BatchSubmitter.Node.Syncing != nil && *status.BatchSubmitter.Node.Syncing`
`77`		`- return c.JSON(hostSync && childSync && batchSync)`
	`77`	`+ return c.JSON(hostSync \|\| childSync \|\| batchSync)`
`78`	`78`	`})`
`79`	`79`	`}`