Merge pull request #124 from initia-labs/fix/minievm-default-denom

feat: update rollup default denom validation

Author: Benzbeeb

common/validate.go

@@ -76,6 +76,22 @@ func ValidateDenom(denom string) error {
 	return nil
 }
 
+func ValidateDenomWithReserved(reservedDenoms []string) func(denom string) error {
+	return func(denom string) error {
+		if !reDnm.MatchString(denom) {
+			return fmt.Errorf("invalid denom: %s", denom)
+		}
+
+		for _, reserved := range reservedDenoms {
+			if denom == reserved {
+				return fmt.Errorf("denom %s is reserved and cannot be used (reserved denom for this rollup: %v)", denom, reservedDenoms)
+			}
+		}
+
+		return nil
+	}
+}
+
 func NoOps(_ string) error {
 	return nil
 }

models/minitia/constants.go

@@ -34,6 +34,9 @@ const (
 	DefaultMinitiaLCD     string = "http://localhost:1317"
 	DefaultMinitiaRPC     string = "http://localhost:26657"
 	DefaultMinitiaJsonRPC string = "http://localhost:8545"
+
+	DefaultRollupDenom  string = "umin"
+	DefaultMinievmDenom string = "GAS"
 )
 
 var (

models/minitia/launch.go

@@ -344,8 +344,8 @@ func (m *VMTypeSelect) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 		state.weave.PushPreviousResponse(styles.RenderPreviousResponse(styles.ArrowSeparator, m.GetQuestion(), m.highlights, string(*selected)))
 		state.vmType = string(*selected)
-		model := NewLatestVersionLoading(weavecontext.SetCurrentState(m.Ctx, state))
 
+		model := NewLatestVersionLoading(weavecontext.SetCurrentState(m.Ctx, state))
 		return model, model.Init()
 	}
 
@@ -485,16 +485,28 @@ type GasDenomInput struct {
 }
 
 func NewGasDenomInput(ctx context.Context) *GasDenomInput {
+	var defaultDenom string
+	var validateFn func(s string) error
+
+	state := weavecontext.GetCurrentState[LaunchState](ctx)
+	if state.vmType == string(EVM) {
+		defaultDenom = DefaultMinievmDenom
+		validateFn = common.ValidateDenomWithReserved([]string{DefaultRollupDenom})
+	} else {
+		defaultDenom = DefaultRollupDenom
+		validateFn = common.ValidateDenom
+	}
+
 	toolTip := tooltip.RollupGasDenomTooltip
 	model := &GasDenomInput{
 		TextInput:  ui.NewTextInput(false),
 		BaseModel:  weavecontext.BaseModel{Ctx: ctx},
 		question:   "Specify rollup gas denom",
 		highlights: []string{"rollup gas denom"},
 	}
-	model.WithPlaceholder(`Press tab to use "umin"`)
-	model.WithDefaultValue("umin")
-	model.WithValidatorFn(common.ValidateDenom)
+	model.WithPlaceholder(fmt.Sprintf(`Press tab to use "%s"`, defaultDenom))
+	model.WithDefaultValue(defaultDenom)
+	model.WithValidatorFn(validateFn)
 	model.WithTooltip(&toolTip)
 	return model
 }