fixup! feat(input-selection): add large first input selection strategy

Author: AngelCastilloB

packages/input-selection/src/GreedySelection/util.ts

@@ -318,7 +318,7 @@ export const splitChangeAndComputeFee = async (
     fee
   );
 
-  // If the newly computed fee is higher than tha available balance for change,
+  // If the newly computed fee is higher than the available balance for change,
   // but there are unallocated native assets, return the assets as change with 0n coins.
   if (adjustedChangeOutputs.fee >= changeLovelace) {
     const result = {

packages/input-selection/src/LargeFirstSelection/LargeFirstInputSelector.ts

@@ -59,7 +59,7 @@ export interface LargeFirstSelectorProps {
 /**
  * Input selector that implements a "large-first" strategy.
  *
- * This strategy selects the largest UTXOs per asset, one asset at a time, until the requirements
+ * This strategy selects the largest UTxOs per asset, one asset at a time, until the requirements
  * of all assets in the outputs + fees and implicit values are satisfied.
  */
 export class LargeFirstSelector implements InputSelector {
@@ -72,11 +72,11 @@ export class LargeFirstSelector implements InputSelector {
 
   /**
    * Selects inputs using a large-first strategy:
-   * Selects largest UTXOs per asset until target is met
-   * Then selects largest UTxOs by ADA
+   * Selects largest UTxOs per asset until target is met
+   * Then selects largest UTxOs by Ada
    * Then iteratively adds more UTxOs if needed to cover fees
    *
-   * @param params Input selection parameters (available UTXOs, outputs, constraints, etc.)
+   * @param params Input selection parameters (available UTxOs, outputs, constraints, etc.)
    * @returns A complete selection including inputs, outputs, change, and fee.
    * @throws {InputSelectionError} If the selection cannot satisfy the outputs and fees.
    */
@@ -197,7 +197,7 @@ export class LargeFirstSelector implements InputSelector {
    * Minting and burning are treated as negative or positive contributions to input balance,
    * and are subtracted from the output requirements.
    *
-   * @param inputs The full set of selected UTXOs (including pre-selected).
+   * @param inputs The full set of selected UTxOs (including pre-selected).
    * @param outputs The transaction outputs.
    * @param implicitValue Optional implicit values including deposits, withdrawals, and minting.
    * @returns An object with:
@@ -235,12 +235,12 @@ export class LargeFirstSelector implements InputSelector {
   }
 
   /**
-   * Selects the largest UTXOs per required asset until each target amount is fulfilled.
+   * Selects the largest UTxOs per required asset until each target amount is fulfilled.
    *
    * @param requiredAssets The asset quantities required by the transaction outputs.
-   * @param allAvailable All available UTXOs (including preselected ones).
-   * @param preSelected The UTXOs already selected for the transaction.
-   * @returns A set of selected UTXOs covering the asset requirements.
+   * @param allAvailable All available UTxOs (including preselected ones).
+   * @param preSelected The UTxOs already selected for the transaction.
+   * @returns A set of selected UTxOs covering the asset requirements.
    * @throws {InputSelectionError} If any asset cannot be sufficiently fulfilled.
    */
   #selectAssets(
@@ -270,13 +270,13 @@ export class LargeFirstSelector implements InputSelector {
   }
 
   /**
-   * Selects UTXOs (largest ADA first) until the total Lovelace covers the target amount.
+   * Selects UTxOs (largest Ada first) until the total Lovelace covers the target amount.
    *
    * @param target The required amount of Lovelace.
-   * @param allAvailable All available UTXOs.
-   * @param selected The current set of already selected UTXOs.
+   * @param allAvailable All available UTxOs.
+   * @param selected The current set of already selected UTxOs.
    * @param implicitCoinInput The implicit coin input amount.
-   * @returns A new set including the original selected UTXOs plus any added for ADA coverage.
+   * @returns A new set including the original selected UTxOs plus any added for Ada coverage.
    * @throws {InputSelectionError} If the Lovelace requirement cannot be fulfilled.
    */
   #selectLovelace(
@@ -311,26 +311,26 @@ export class LargeFirstSelector implements InputSelector {
   }
 
   /**
-   * Computes the UTXOs that were not selected, given the original list and selected set.
+   * Computes the UTxOs that were not selected, given the original list and selected set.
    *
-   * @param original The original list of available UTXOs (excluding preselected).
-   * @param used The set of selected UTXOs.
-   * @returns A new set of UTXOs that were not consumed in the transaction.
+   * @param original The original list of available UTxOs (excluding preselected).
+   * @param used The set of selected UTxOs.
+   * @returns A new set of UTxOs that were not consumed in the transaction.
    */
   #computeRemainingUtxo(original: Cardano.Utxo[], used: Set<Cardano.Utxo>): Set<Cardano.Utxo> {
     const usedTxIns = new Set([...used].map(([txIn]) => txIn));
     return new Set(original.filter(([txIn]) => !usedTxIns.has(txIn)));
   }
 
   /**
-   * Select additional UTXOs until the fee and min-ADA requirements are
+   * Select additional UTxOs until the fee and min-Ada requirements are
    * satisfied, then build the final change outputs.
    *
-   * @param initialInputs The UTXOs already chosen for assets and/or pre-selected by the wallet.
+   * @param initialInputs The UTxOs already chosen for assets and/or pre-selected by the wallet.
    * @param outputs The explicit transaction outputs.
-   * @param allAvailable Every UTXO the wallet can spend (pre-selected ∪ utxo).
-   * @param requiredAssets Aggregate asset requirements computed from `outputs` + burn.  Used for fee/ADA expansion.
-   * @param constraints Network / wallet selection constraints (min-ADA, fee estimator, bundle size, limit…).
+   * @param allAvailable Every UTxO the wallet can spend (pre-selected ∪ utxo).
+   * @param requiredAssets Aggregate asset requirements computed from `outputs` + burn.  Used for fee/Ada expansion.
+   * @param constraints Network / wallet selection constraints (min-Ada, fee estimator, bundle size, limit…).
    * @param changeAddressResolver Callback that assigns addresses (or further splits) for the provisional change bundles returned by the fee engine.
    * @param implicitValue Optional implicit components (deposits, withdrawals, mint or burn)
    * @returns An object containing Set of all inputs that will appear in the tx body, minimum fee returned by the cost model and an Array of change outputs.
@@ -347,7 +347,7 @@ export class LargeFirstSelector implements InputSelector {
     const utxoSelectedArr = [...initialInputs];
     const utxoRemainingArr = allAvailable
       .filter((u) => !initialInputs.has(u))
-      .sort(([, a], [, b]) => sortByCoins(a, b)); // ADA-descending
+      .sort(([, a], [, b]) => sortByCoins(a, b)); // Ada-descending
 
     const outputValues = toValues([...outputs]);