fix(cardano-services): use computed stake credential type while building certificates

Author: iccicci

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/mappers.ts

@@ -231,25 +231,15 @@ export const mapCertificate = (
         : Cardano.CertificateType.Unregistration,
       cert_index: certModel.cert_index,
       deposit: BigInt(certModel.deposit),
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     } as WithCertIndex<Cardano.NewStakeAddressCertificate>;
 
   if (isDelegationCertModel(certModel))
     return {
       __typename: Cardano.CertificateType.StakeDelegation,
       cert_index: certModel.cert_index,
       poolId: certModel.pool_id as unknown as Cardano.PoolId,
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     } as WithCertIndex<Cardano.StakeDelegationCertificate>;
 
   if (isDrepRegistrationCertModel(certModel))
@@ -292,12 +282,7 @@ export const mapCertificate = (
       __typename: Cardano.CertificateType.VoteDelegation,
       cert_index: certModel.cert_index,
       dRep: mapDrepDelegation(certModel),
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     };
 
   if (isVoteRegistrationDelegationCertModel(certModel))
@@ -306,12 +291,7 @@ export const mapCertificate = (
       cert_index: certModel.cert_index,
       dRep: mapDrepDelegation(certModel),
       deposit: BigInt(certModel.deposit),
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     };
 
   if (isStakeVoteDelegationCertModel(certModel))
@@ -320,12 +300,7 @@ export const mapCertificate = (
       cert_index: certModel.cert_index,
       dRep: mapDrepDelegation(certModel),
       poolId: certModel.pool_id as unknown as Cardano.PoolId,
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     };
 
   if (isStakeRegistrationDelegationCertModel(certModel))
@@ -334,12 +309,7 @@ export const mapCertificate = (
       cert_index: certModel.cert_index,
       deposit: BigInt(certModel.deposit),
       poolId: certModel.pool_id as unknown as Cardano.PoolId,
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     };
 
   if (isStakeVoteRegistrationDelegationCertModel(certModel))
@@ -349,12 +319,7 @@ export const mapCertificate = (
       dRep: mapDrepDelegation(certModel),
       deposit: BigInt(certModel.deposit),
       poolId: certModel.pool_id as unknown as Cardano.PoolId,
-      stakeCredential: {
-        hash: Cardano.RewardAccount.toHash(
-          Cardano.RewardAccount(certModel.address)
-        ) as unknown as Crypto.Hash28ByteBase16,
-        type: Cardano.CredentialType.KeyHash
-      }
+      stakeCredential: Cardano.Address.fromBech32(certModel.address).asReward()!.getPaymentCredential()
     };
 
   if (isAuthorizeCommitteeHotCertModel(certModel))

packages/e2e/test/wallet_epoch_3/SharedWallet/delegation.test.ts

@@ -1,6 +1,6 @@
 /* eslint-disable max-statements */
 import { BaseWallet, ObservableWallet } from '@cardano-sdk/wallet';
-import { BigIntMath, isNotNil } from '@cardano-sdk/util';
+import { BigIntMath, isNotNil, toSerializableObject } from '@cardano-sdk/util';
 import { Cardano, Serialization, StakePoolProvider } from '@cardano-sdk/core';
 import {
   TX_TIMEOUT_DEFAULT,
@@ -204,6 +204,16 @@ describe('SharedWallet/delegation', () => {
     await waitForTx(aliceMultiSigWallet, tx.id);
     const tx1ConfirmedState = await getWalletStateSnapshot(aliceMultiSigWallet);
 
+    // Check Registration and StakeDelegation certificate from ChainHistoryProvider
+    let gotTx = toSerializableObject(
+      (await firstValueFrom(aliceMultiSigWallet.transactions.history$)).find((t) => tx.id === t.id)!
+    );
+    // These are required because txBuilder still uses StakeRegistration
+    (gotTx as Cardano.HydratedTx).body.certificates![0].__typename = Cardano.CertificateType.StakeRegistration;
+    delete ((gotTx as Cardano.HydratedTx).body.certificates![0] as Partial<Cardano.NewStakeAddressCertificate>).deposit;
+    expect((gotTx as Cardano.HydratedTx).body.certificates?.length).toEqual(2);
+    expect((gotTx as Cardano.HydratedTx).body.certificates).toEqual(toSerializableObject(tx.body.certificates));
+
     // Updates total and available balance after tx is on-chain
     expect(tx1ConfirmedState.balance.total.coins).toBe(expectedCoinsAfterTx1);
     expect(tx1ConfirmedState.balance.total).toEqual(tx1ConfirmedState.balance.available);
@@ -237,6 +247,16 @@ describe('SharedWallet/delegation', () => {
     await waitForTx(aliceMultiSigWallet, tx.id);
     const tx2ConfirmedState = await getWalletStateSnapshot(aliceMultiSigWallet);
 
+    // Check Unregistration certificate from ChainHistoryProvider
+    gotTx = toSerializableObject(
+      (await firstValueFrom(aliceMultiSigWallet.transactions.history$)).find((t) => tx.id === t.id)!
+    );
+    // These are required because txBuilder still uses StakeDeregistration
+    (gotTx as Cardano.HydratedTx).body.certificates![0].__typename = Cardano.CertificateType.StakeDeregistration;
+    delete ((gotTx as Cardano.HydratedTx).body.certificates![0] as Partial<Cardano.NewStakeAddressCertificate>).deposit;
+    expect((gotTx as Cardano.HydratedTx).body.certificates?.length).toEqual(1);
+    expect((gotTx as Cardano.HydratedTx).body.certificates).toEqual(toSerializableObject(tx.body.certificates));
+
     // No longer delegating
     expect(tx2ConfirmedState.rewardAccount.delegatee?.nextNextEpoch?.id).toBeUndefined();
     expect(tx2ConfirmedState.rewardAccount.credentialStatus).toBe(Cardano.StakeCredentialStatus.Unregistered);