fix(tx-construction): use output address size as minimum coin computation param

OutputValidator.validateOutput used a stub shelley address, which computed
an invalid minimum coin quantity for outputs to Byron address that are
larger in bytes, therefore actually requiring more coins than computed

Author: mkazlauskas

packages/tx-construction/src/output-validation/outputValidator.ts

@@ -12,15 +12,12 @@ import { computeMinimumCoinQuantity, tokenBundleSizeExceedsLimit } from '../inpu
 export const createOutputValidator = ({
   protocolParameters: protocolParametersGetter
 }: OutputValidatorContext): OutputValidator => {
-  const validateValue = async (
-    value: Cardano.Value,
+  const validateOutput = async (
+    { address, value }: Cardano.TxOut,
     protocolParameters?: ProtocolParametersRequiredByOutputValidator
-  ): Promise<OutputValidation> => {
+  ) => {
     const { coinsPerUtxoByte, maxValueSize } = protocolParameters || (await protocolParametersGetter());
-    const stubMaxSizeAddress = Cardano.PaymentAddress(
-      'addr_test1qqydn46r6mhge0kfpqmt36m6q43knzsd9ga32n96m89px3nuzcjqw982pcftgx53fu5527z2cj2tkx2h8ux2vxsg475qypp3m9'
-    );
-    const stubTxOut: Cardano.TxOut = { address: stubMaxSizeAddress, value };
+    const stubTxOut: Cardano.TxOut = { address, value };
     const negativeAssetQty = value.assets ? [...value.assets.values()].some((qty) => qty <= 0) : false;
     if (negativeAssetQty) {
       // return early, otherwise 'minimumCoin/maxValueSize' will fail with error: "ParseIntError { kind: InvalidDigit }"
@@ -39,10 +36,6 @@ export const createOutputValidator = ({
       tokenBundleSizeExceedsLimit: tokenBundleSizeExceedsLimit(maxValueSize)(value.assets)
     };
   };
-  const validateOutput = async (
-    output: Cardano.TxOut,
-    protocolParameters?: ProtocolParametersRequiredByOutputValidator
-  ) => validateValue(output.value, protocolParameters);
 
   return {
     validateOutput,

packages/tx-construction/test/output-validation/outputValidator.test.ts

@@ -96,5 +96,22 @@ describe('createOutputValidator', () => {
         ).negativeAssetQty
       ).toBe(true);
     });
+
+    it('uses output address size as minimum coin computation parameter', async () => {
+      const value: Cardano.Value = { coins: 123n };
+      const { minimumCoin: byronAddressMinimumCoin } = await validator.validateOutput({
+        address: Cardano.PaymentAddress(
+          'DdzFFzCqrht4PWfBGtmrQz4x1GkZHYLVGbK7aaBkjWxujxzz3L5GxCgPiTsks5RjUr3yX9KvwKjNJBt7ZzPCmS3fUQrGeRvo9Y1YBQKQ'
+        ),
+        value
+      });
+      const { minimumCoin: shelleyAddressMinimumCoin } = await validator.validateOutput({
+        address: Cardano.PaymentAddress(
+          'addr_test1qqydn46r6mhge0kfpqmt36m6q43knzsd9ga32n96m89px3nuzcjqw982pcftgx53fu5527z2cj2tkx2h8ux2vxsg475qypp3m9'
+        ),
+        value
+      });
+      expect(byronAddressMinimumCoin).toBeGreaterThan(shelleyAddressMinimumCoin);
+    });
   });
 });