fixup! feat(cardano-services): blockfrost chain history provider now caches transactions locally

Author: AngelCastilloB

packages/cardano-services-client/src/ChainHistoryProvider/BlockfrostChainHistoryProvider.ts

@@ -476,31 +476,20 @@ export class BlockfrostChainHistoryProvider extends BlockfrostProvider implement
   }
 
   public async transactionsByHashes({ ids }: TransactionsByIdsArgs): Promise<Cardano.HydratedTx[]> {
-    const cachedTransactions: Cardano.HydratedTx[] = [];
-    const idsToFetch: Cardano.TransactionId[] = [];
-
-    for (const id of ids) {
-      if (this.cache.has(id)) {
-        cachedTransactions.push(this.cache.get(id)!);
-      } else {
-        idsToFetch.push(id);
-      }
-    }
-
-    let fetchedTransactions: Cardano.HydratedTx[] = [];
-    if (idsToFetch.length > 0) {
-      try {
-        fetchedTransactions = await Promise.all(idsToFetch.map((id) => this.fetchTransaction(id)));
-
-        for (const tx of fetchedTransactions) {
-          this.cache.set(tx.id, tx);
+    return Promise.all(
+      ids.map(async (id) => {
+        if (this.cache.has(id)) {
+          return this.cache.get(id)!;
         }
-      } catch (error) {
-        throw this.toProviderError(error);
-      }
-    }
-
-    return [...cachedTransactions, ...fetchedTransactions];
+        try {
+          const fetchedTransaction = await this.fetchTransaction(id);
+          this.cache.set(id, fetchedTransaction);
+          return fetchedTransaction;
+        } catch (error) {
+          throw this.toProviderError(error);
+        }
+      })
+    );
   }
 
   // eslint-disable-next-line sonarjs/cognitive-complexity