From 79a9822ee2505e999741a1cc3404fea17de82f9d Mon Sep 17 00:00:00 2001 From: Lukasz Jagiela <12641433+ljagiela@users.noreply.github.com> Date: Mon, 17 Feb 2025 09:17:14 +0100 Subject: [PATCH] test: minor test fixes (maintenance) (#1716) --- packages/e2e-tests/src/assert/transactionDetailsAssert.ts | 3 ++- .../src/features/e2e/SendTransactionSimpleExtendedE2E.feature | 2 ++ .../src/features/e2e/SendTransactionSimplePopupE2E.feature | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/e2e-tests/src/assert/transactionDetailsAssert.ts b/packages/e2e-tests/src/assert/transactionDetailsAssert.ts index abd3604057..bb63e67fd4 100644 --- a/packages/e2e-tests/src/assert/transactionDetailsAssert.ts +++ b/packages/e2e-tests/src/assert/transactionDetailsAssert.ts @@ -242,8 +242,9 @@ class TransactionsDetailsAssert { async assertSeeActivityDetailsSummaryAmounts(mode: 'extended' | 'popup') { await this.waitForTransactionsLoaded(); const rowsNumber = (await TransactionsPage.rows).length; + const maxRowsIterator = mode === 'extended' ? 8 : 6; - for (let i = 0; i <= rowsNumber && i < 10; i++) { + for (let i = 0; i <= rowsNumber && i < maxRowsIterator; i++) { const skippedTransaction = ['Self Transaction', 'Rewards']; // should be covered in separate tests if (!skippedTransaction.includes(await TransactionsPage.transactionsTableItemType(i).getText())) { await TransactionsPage.clickOnTransactionRow(i); diff --git a/packages/e2e-tests/src/features/e2e/SendTransactionSimpleExtendedE2E.feature b/packages/e2e-tests/src/features/e2e/SendTransactionSimpleExtendedE2E.feature index 06f4cbe7c3..c7e2630a11 100644 --- a/packages/e2e-tests/src/features/e2e/SendTransactionSimpleExtendedE2E.feature +++ b/packages/e2e-tests/src/features/e2e/SendTransactionSimpleExtendedE2E.feature @@ -62,6 +62,8 @@ Feature: Send Simple Transactions - Extended view - E2E Then I see a toast with text: "Copied to clipboard" And I see 1 opened tab(s) When I wait for the transaction history to be loaded and all transactions to be confirmed + And I close the drawer by clicking close button + And I click on a transaction: 1 And I click on a transaction hash and save hash information Then I see 2 opened tab(s) When I switch to last window diff --git a/packages/e2e-tests/src/features/e2e/SendTransactionSimplePopupE2E.feature b/packages/e2e-tests/src/features/e2e/SendTransactionSimplePopupE2E.feature index 17af6b983b..f3ccfb10a8 100644 --- a/packages/e2e-tests/src/features/e2e/SendTransactionSimplePopupE2E.feature +++ b/packages/e2e-tests/src/features/e2e/SendTransactionSimplePopupE2E.feature @@ -61,6 +61,9 @@ Feature: Send Simple Transactions - Popup view - E2E Then I see a toast with text: "Copied to clipboard" And I see 1 opened tab(s) When I wait for the transaction history to be loaded and all transactions to be confirmed + And I close the drawer by clicking close button + And I navigate to Activity popup page + And I click on a transaction: 1 And I click on a transaction hash and save hash information Then I see 2 opened tab(s) When I switch to last window