Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set default local-env image to v1.5.0 #499

Merged
merged 1 commit into from
Feb 18, 2025
Merged

chore: set default local-env image to v1.5.0 #499

merged 1 commit into from
Feb 18, 2025

Conversation

rsporny
Copy link
Collaborator

@rsporny rsporny commented Feb 17, 2025

chore: set default local-env image to v1.5.0

LGLO
LGLO approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I really think we should just remove default PC node image. CI has to override it. When developing anything around node and using local-env for tests one also has to override it.

@rsporny rsporny force-pushed the bump-default-local-env-image branch from 05ecd08 to e8f5b70 Compare February 18, 2025 08:15
@rsporny rsporny merged commit 16d3d50 into master Feb 18, 2025
23 checks passed
@rsporny rsporny deleted the bump-default-local-env-image branch February 18, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LGLO LGLO LGLO approved these changes

@AmbientTea AmbientTea Awaiting requested review from AmbientTea

@skylar-simoncelli skylar-simoncelli Awaiting requested review from skylar-simoncelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsporny @LGLO