Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: differentiate two types of candidates in selection process #504

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Feb 19, 2025

Description

Introduces separate types for permissioned/trustless candidates so in the future we could preserve that information in committee data on-chain. I think this shouldn't break existing chains but I will need to check that.

UPDATE: Tested this successfully with runtime upgrade on devnet.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea force-pushed the differentiate-candidate-types branch from 21350db to 00578f9 Compare February 19, 2025 12:09
@AmbientTea AmbientTea marked this pull request as ready for review February 19, 2025 12:38
@AmbientTea AmbientTea merged commit c54ec6e into master Feb 20, 2025
23 checks passed
@AmbientTea AmbientTea deleted the differentiate-candidate-types branch February 20, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants