Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCM-8543 Fix test_block_headers_have_mc_hash #505

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

kpinter-iohk
Copy link
Contributor

Description

  • Adds OFFSET to test_block_headers_have_mc_hash based on specs, allowing for small discrepancy, but logging a warning
  • Some improvements to docs

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@kpinter-iohk kpinter-iohk merged commit fa6528d into master Feb 19, 2025
23 checks passed
@kpinter-iohk kpinter-iohk deleted the ETCM-8543 branch February 19, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants