Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python to 3.12 #509

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Update python to 3.12 #509

merged 1 commit into from
Feb 26, 2025

Conversation

gilligan
Copy link
Contributor

@gilligan gilligan commented Feb 20, 2025

Description

Provide python 3.12 in the nix shell (previously we were on 3.11)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@gilligan
Copy link
Contributor Author

At this point I'm not entirely sure if I shouldn't just remove python from the nix shell completely seeing how it's currently causing problems with the use of numpy anyway.
I'm leaning towards removing it and just assuming that python needs to be installed individually.
@rsporny you probably don't mind either way?

@rsporny
Copy link
Collaborator

rsporny commented Feb 26, 2025

@gilligan I don't mind, I checked out this branch and it works fine. I'll switch to using devshell's python if we merge it.

@gilligan gilligan merged commit 8e4cd4e into master Feb 26, 2025
23 checks passed
@gilligan gilligan deleted the use-python-3.12 branch February 26, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants