CLI deployment of Wst using Blockfrost #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirmrad
force-pushed
the
amir/deploy-all
branch
from
e01b4ca to
88b78c6
Compare
j-mueller
reviewed
Jan 13, 2025
| let root = DirectoryScriptRoot txi target | ||
| (tx, _) <- Env.withEnv $ Env.withOperator opEnv $ Env.withDirectoryFor root $ Env.withTransferFromOperator | ||
| $ Env.balanceTxEnv_ | ||
| $ BuildTx.mintProtocolParams |
|
The missing ToSchema instance can be added to |
amirmrad
force-pushed
the
amir/deploy-all
branch
from
320b7ec to
796332c
Compare
amirmrad
commented
Jan 14, 2025
| @@ -131,6 +135,13 @@ insertBlacklistNode cred blacklistNodes = Utils.inBabbage @era $ do | |||
| opPkh <- asks (fst . Env.bteOperator . Env.operatorEnv) | |||
| addRequiredSignature opPkh | |||
|
|
|||
| spendBlacklistOutput :: forall era env m. (MonadReader env m, Env.HasOperatorEnv era env, Env.HasTransferLogicEnv env, C.IsBabbageBasedEra era, C.HasScriptLanguageInEra C.PlutusScriptV3 era, MonadBuildTx era m) => C.TxIn -> m () | |||
There was a problem hiding this comment.
This is currently unused in the endpoints. I only needed it to remove a duplicate blacklist node I accidentally pushed on preview. We could later cleanup the interface and add an endpoint if need be.
amirmrad
commented
Jan 14, 2025
| addConwayStakeCredentialCertificate credMinting | ||
| addConwayStakeCredentialCertificate credSpending | ||
| addConwayStakeCredentialCertificate credSeizeSpending |
There was a problem hiding this comment.
Registration step for transfer script was missing issuer spend (seize) stake script
amirmrad
commented
Jan 14, 2025
| @@ -216,7 +216,17 @@ seizeCredentialAssetsTx :: forall era env m. | |||
| seizeCredentialAssetsTx sanctionedCred = do | |||
| opPkh <- asks (fst . Env.bteOperator . Env.operatorEnv) | |||
| directory <- Query.registryNodes @era | |||
| seizeTxo <- head <$> Query.userProgrammableOutputs sanctionedCred | |||
| let getTxOutValue (C.TxOut _a v _d _r) = v | |||
There was a problem hiding this comment.
Just selects the UTxO with the largest non ada asset quantities ignoring the asset names.
To seize all utxos the endpoints must be repeatedly called until NoTokensToSeize is returned.
amirmrad
commented
Jan 14, 2025
| @@ -130,7 +131,8 @@ queryBlacklistedNodes _ (SerialiseAddress addr) = do | |||
| . P.fromBuiltin | |||
| . blnKey | |||
| . uDatum | |||
| Env.withEnv $ Env.withTransfer transferLogic (fmap (fmap getHash) (Query.blacklistNodes @era)) | |||
| nonHeadNodes (P.fromBuiltin . blnKey . uDatum -> hsh) = hsh /= "" | |||
| Env.withEnv $ Env.withTransfer transferLogic (fmap getHash . filter nonHeadNodes <$> (Query.blacklistNodes @era)) | |||
There was a problem hiding this comment.
Desezialization would fail in the case of the head node with an empty payment credential
j-mueller
approved these changes
Jan 14, 2025
amirmrad
force-pushed
the
amir/deploy-all
branch
from
0039317 to
7ff604e
Compare
amirmrad
force-pushed
the
amir/deploy-all
branch
from
7ff604e to
4c40704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.