Skip to content

1040 rtables round type#277

Merged
gmbecker merged 17 commits into
mainfrom
1040_rtables_round_type
Dec 5, 2025
Merged

1040 rtables round type#277
gmbecker merged 17 commits into
mainfrom
1040_rtables_round_type

Conversation

@iaugusty

Copy link
Copy Markdown
Collaborator

this PR is linked to rtables issue insightsengineering/rtables#1040

@github-actions

github-actions Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@iaugusty

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@iaugusty

Copy link
Copy Markdown
Collaborator Author

@shajoezhu This PR depends on formatters pull request insightsengineering/formatters#366.
How to get the github actions to use the proper formatters version?

@edelarua edelarua mentioned this pull request Nov 27, 2025
33 tasks
@github-actions

github-actions Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      140      17  87.86%   40-41, 43, 73, 92, 96, 196-199, 202, 286-292
R/rlistings.R              367      25  93.19%   237-244, 370, 379, 460, 644-647, 651-654, 683-684, 725-728
TOTAL                      536      42  92.16%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/rlistings_methods.R       +4       0  +0.36%
R/rlistings.R               +2       0  +0.04%
TOTAL                       +6       0  +0.09%

Results for commit: c7ad19e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files    5 suites   9s ⏱️
 51 tests  45 ✅  6 💤 0 ❌
176 runs  156 ✅ 20 💤 0 ❌

Results for commit c7ad19e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
paginate_listing 💚 $7.15$ $-2.83$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
listings 👶 $+0.08$ round_type_approach_works
listings 👶 $+0.08$ round_type_getter_and_setter_on_list_of_listing_df

Results for commit 5f46d28

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! this is working thanks! see insightsengineering/scda.test#201

@shajoezhu

Copy link
Copy Markdown
Collaborator

downstream all good! insightsengineering/scda.test#201 thanks guys!

@gmbecker gmbecker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good some small notes/needed tests

Comment thread R/rlistings.R Outdated
Comment thread tests/testthat/test-listings.R
@iaugusty

iaugusty commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator Author

@gmbecker all review comments addressed as per discussion

@shajoezhu

Copy link
Copy Markdown
Collaborator

hi @gmbecker , can you fix the lintr issue please. thanks!

@gmbecker

gmbecker commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

Ugh, so apparently we do need to use %>% in at least one place, because we're using . somewhere. So the linter was just wrong. Will push reversion but since when does the superlinter complain about this @shajoezhu?

@gmbecker gmbecker merged commit fbbf0db into main Dec 5, 2025
28 checks passed
@gmbecker gmbecker deleted the 1040_rtables_round_type branch December 5, 2025 23:47
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants