1040 rtables round type#277
Conversation
|
✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
|
@shajoezhu This PR depends on formatters pull request insightsengineering/formatters#366. |
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Code Coverage SummaryDiff against mainResults for commit: c7ad19e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 5 suites 9s ⏱️ Results for commit c7ad19e. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 5f46d28 ♻️ This comment has been updated with latest results. |
shajoezhu
left a comment
There was a problem hiding this comment.
awesome! this is working thanks! see insightsengineering/scda.test#201
|
downstream all good! insightsengineering/scda.test#201 thanks guys! |
gmbecker
left a comment
There was a problem hiding this comment.
Looks good some small notes/needed tests
|
@gmbecker all review comments addressed as per discussion |
|
hi @gmbecker , can you fix the lintr issue please. thanks! |
|
Ugh, so apparently we do need to use %>% in at least one place, because we're using |
this PR is linked to rtables issue insightsengineering/rtables#1040