Skip to content

Commit ae1a386

Browse files
averissimopawelru
andauthored
Adds min package version (#1012)
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #957 ### 🔴 Checklist for PR Reviewer [![Scheduled 🕰️](https://github.com/insightsengineering/tern/actions/workflows/scheduled.yaml/badge.svg?branch=verdepcheck_action)](https://github.com/insightsengineering/tern/actions/workflows/scheduled.yaml) _(~~max strategy fails due to tidyverse/ggplot2#5436 corrected upstream)_ - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Pawel Rucki <[email protected]>
1 parent 9ec685b commit ae1a386

File tree

3 files changed

+83
-53
lines changed

3 files changed

+83
-53
lines changed

.github/workflows/scheduled.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
test-strategy: ["min", "release", "max"]
14+
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
1515
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
1616
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
1717
secrets:

DESCRIPTION

+49-22
Original file line numberDiff line numberDiff line change
@@ -23,44 +23,71 @@ Depends:
2323
R (>= 3.6),
2424
rtables (>= 0.6.5)
2525
Imports:
26-
broom,
27-
car,
28-
checkmate,
29-
cowplot,
30-
dplyr,
31-
emmeans (>= 1.4.5),
26+
broom (>= 0.5.4),
27+
car (>= 3.0-13),
28+
checkmate (>= 2.1.0),
29+
cowplot (>= 0.7.0),
30+
dplyr (>= 1.0.0),
31+
emmeans (>= 1.8.0),
3232
forcats (>= 1.0.0),
3333
formatters (>= 0.5.4),
3434
ggplot2 (>= 3.4.0),
3535
grid,
36-
gridExtra,
37-
gtable,
36+
gridExtra (>= 2.0.0),
37+
gtable (>= 0.3.0),
3838
labeling,
39-
lifecycle,
40-
magrittr,
39+
lifecycle (>= 0.2.0),
40+
magrittr (>= 1.5),
4141
methods,
42-
Rdpack,
43-
rlang,
44-
scales,
42+
Rdpack (>= 2.4),
43+
rlang (>= 1.1.0),
44+
scales (>= 1.2.0),
4545
stats,
4646
survival (>= 3.2-13),
47-
tibble,
48-
tidyr,
47+
tibble (>= 2.0.0),
48+
tidyr (>= 0.8.3),
4949
utils
5050
Suggests:
51-
knitr,
52-
lattice,
53-
lubridate,
51+
knitr (>= 1.42),
52+
lattice (>= 0.18-4),
53+
lubridate (>= 1.7.9),
5454
nestcolor (>= 0.1.1),
55-
rmarkdown,
56-
stringr,
57-
testthat (>= 3.0),
58-
vdiffr (>= 1.0.0)
55+
rmarkdown (>= 2.19),
56+
stringr (>= 1.4.1),
57+
testthat (>= 3.1.9),
58+
vdiffr (>= 1.0.7)
5959
VignetteBuilder:
6060
knitr
6161
RdMacros:
6262
lifecycle,
6363
Rdpack
64+
Config/Needs/verdepcheck:
65+
insightsengineering/rtables,
66+
tidymodels/broom,
67+
cran/car,
68+
mllg/checkmate,
69+
wilkelab/cowplot,
70+
tidyverse/dplyr,
71+
rvlenth/emmeans,
72+
tidyverse/forcats,
73+
insightsengineering/formatters,
74+
tidyverse/ggplot2,
75+
r-lib/gtable,
76+
r-lib/lifecycle,
77+
tidyverse/magrittr,
78+
GeoBosh/Rdpack,
79+
r-lib/rlang,
80+
r-lib/scales,
81+
tidyverse/tibble,
82+
tidyverse/tidyr,
83+
yihui/knitr,
84+
deepayan/lattice,
85+
tidyverse/lubridate,
86+
insightsengineering/nestcolor,
87+
rstudio/rmarkdown,
88+
tidyverse/stringr,
89+
r-lib/testthat,
90+
r-lib/vdiffr
6491
Config/Needs/website: insightsengineering/nesttemplate
6592
Config/testthat/edition: 3
6693
Encoding: UTF-8

NEWS.md

+33-30
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# tern 0.9.2.9000
22

3+
### Miscellaneous
4+
* Specified minimal version of package dependencies.
5+
36
# tern 0.9.2
47

58
### New Features
@@ -65,7 +68,7 @@
6568
### Enhancements
6669
* Added `ylim` argument to `g_km` to allow the user to set custom limits for the y-axis.
6770
* Added assertion to `g_km` which checks whether there is one arm present in the data when `annot_coxph` is true.
68-
* Added `flag_labels` argument to `s_count_patients_with_flags` to enable more label handling options in `count_patients_by_flags`.
71+
* Added `flag_labels` argument to `s_count_patients_with_flags` to enable more label handling options in `count_patients_by_flags`.
6972
* Added the `nested` argument to `analyze` wrapper functions `count_abnormal`, `count_abnormal_by_baseline`, `count_abnormal_by_marked`, `count_abnormal_by_worst_grade`, `count_abnormal_lab_worsen_by_baseline`, `count_cumulative`, `count_missed_doses`, `count_occurrences`, `count_occurrences_by_grade`, `count_patients_with_event`, `count_patients_with_flags`, `count_values`, `estimate_multinomial_response`, `estimate_proportion`, `estimate_incidence_rate`, `estimate_odds_ratio`, `estimate_proportion_diff`, `test_proportion_diff`, `summarize_ancova`, `summarize_change`, `summarize_glm_count`, `analyze_num_patients`, `coxph_pairwise`, `surv_time`, and `surv_timepoint`.
7073

7174
## Miscellaneous
@@ -139,19 +142,19 @@
139142
### Enhancements
140143
* Added `summarize_glm_count` function to analyze count data using a linear model.
141144
* Added legend to `g_step`.
142-
* Added formatting functions `format_fraction_fixed_dp` and
145+
* Added formatting functions `format_fraction_fixed_dp` and
143146
`format_count_fraction_fixed_dp` with fixed single decimal place in percentages.
144147
* Added `na_level` and `labelstr` arguments to `summarize_vars_in_cols`.
145148
* Added `analyze_num_patients` to include summary at the beginning that does not
146149
repeat when paginating.
147150
* Added `h_row_first_values` function as a more general helper function to retrieve
148151
first values from specific rows.
149152
* Added option to remove `"(n)"` suffix from `unique_count` labels for `s_num_patients`.
150-
* Added options to `g_km` to annotate with statistics (`annot_stats`) and add corresponding
153+
* Added options to `g_km` to annotate with statistics (`annot_stats`) and add corresponding
151154
vertical lines (`annot_stats_lines`).
152155

153156
### Bug Fixes
154-
* Fixed bug causing incorrect ordering of numeric grade levels when missing
157+
* Fixed bug causing incorrect ordering of numeric grade levels when missing
155158
grades are present in `s_count_occurrences_by_grade`.
156159
* Refactored `summarize_vars_in_cols` to work with pagination machinery.
157160
* Fixed bug to allow passing of `conf_level` argument to `emmeans::contrast()` in `s_ancova`.
@@ -166,11 +169,11 @@
166169
* Added more tests to increase code coverage.
167170
* Created separate documentation files for functions in different sections of `pkgdown` reference.
168171
* Created separate `.R` files for logistic regression and cox regression helper functions.
169-
* Fixed table tests using `analyze_num_patients` to generate an initial summary so there is no
172+
* Fixed table tests using `analyze_num_patients` to generate an initial summary so there is no
170173
repetition when paginating.
171174
* Updated tests to use `testthat` 3rd edition and replaced applicable tests with snapshot testing.
172175
* Updated `summarize_ancova` examples to use `iris` dataset instead of `scda` data.
173-
* Created vignette which saves cached synthetic `CDISC` dataset files to the `data/` folder and
176+
* Created vignette which saves cached synthetic `CDISC` dataset files to the `data/` folder and
174177
generated cached synthetic datasets.
175178
* Updated all examples/tests to use datasets from the `data/` folder instead of `scda` datasets.
176179
* Removed all template tests from `tern`. These tests are in internal repo `scda.test`.
@@ -189,40 +192,40 @@
189192
### New Features
190193
* Added stratified `Newcombe` and stratified Wilson statistics to `estimate_proportion` and
191194
`estimate_proportion_diff` with relative tests.
192-
* Added `stat_mean_pval`, a new summary statistic to calculate the p-value of
195+
* Added `stat_mean_pval`, a new summary statistic to calculate the p-value of
193196
the mean.
194-
* Added statistic `mean_se` (mean with standard error) for `summarize_variables`
197+
* Added statistic `mean_se` (mean with standard error) for `summarize_variables`
195198
and related functions.
196199
* Introduced again `Rdpack` for references.
197200

198-
### Enhancements
199-
* Redesign of data handling in tests by removing repetitive data loads and
201+
### Enhancements
202+
* Redesign of data handling in tests by removing repetitive data loads and
200203
library calls.
201204
* Added `DescTools::BinomDiffCI` function within `tern`.
202-
* Added new parameter to `summarize_logistic` to specify which pivoted value
205+
* Added new parameter to `summarize_logistic` to specify which pivoted value
203206
to use during analysis.
204-
* Updated `s_coxph_pairwise` to generate log-rank p-value using original
207+
* Updated `s_coxph_pairwise` to generate log-rank p-value using original
205208
log-rank test instead of Cox Proportional-Hazards Model.
206-
* Implemented `nestcolor` in all examples by adapting `g_km`, `g_ipp`,
209+
* Implemented `nestcolor` in all examples by adapting `g_km`, `g_ipp`,
207210
`g_waterfall`, `g_step`, `g_lineplot`, and `g_forest`.
208-
* Added parameters `interaction_y` and `interaction_item` in `ANCOVA` to make the
211+
* Added parameters `interaction_y` and `interaction_item` in `ANCOVA` to make the
209212
interaction calculations available.
210213
* Added new parameter `footnotes` to add footnotes to `g_km`.
211214

212215
### Migration from `assertthat` to `checkmate`
213-
* Implemented `checkmate::assert_vector`, `checkmate::assert_set_equal`, and
216+
* Implemented `checkmate::assert_vector`, `checkmate::assert_set_equal`, and
214217
`checkmate::assert_int` to check vector type, length, and values.
215218
* Replaced with standard assertions from `checkmate` the following functions:
216-
`all_elements_in_ref`, `is_df_with_nlevels_factor`, `is_df_with_no_na_level`,
217-
`is_proportion_vector`, `is_quantiles_vector`, `is_character_or_factor`,
218-
`is_nonnegative_count`, `is_valid_character`, `assert_character_or_factor`,
219+
`all_elements_in_ref`, `is_df_with_nlevels_factor`, `is_df_with_no_na_level`,
220+
`is_proportion_vector`, `is_quantiles_vector`, `is_character_or_factor`,
221+
`is_nonnegative_count`, `is_valid_character`, `assert_character_or_factor`,
219222
`assert_equal_length` and `has_tabletree_colnames`.
220-
* Modified `is_proportion`, `is_equal_length`, `is_df_with_no_na_level`,
221-
`is_df_with_nlevels_factor`, `is_variables`, `is_df_with_variables`,
223+
* Modified `is_proportion`, `is_equal_length`, `is_df_with_no_na_level`,
224+
`is_df_with_nlevels_factor`, `is_variables`, `is_df_with_variables`,
222225
`is_df_with_factors`, `is_valid_factor` to use assertion logic.
223226
* Added more verbose warnings from `as_factor_keep_attributes`.
224227
* Made `assert_df_with_factors` and `assert_proportion_value` internal functions.
225-
* Renamed `assertthat.R` and `test-assertthat.R` to `utils_checkmate.R` and
228+
* Renamed `assertthat.R` and `test-assertthat.R` to `utils_checkmate.R` and
226229
`test-utils_checkmate.R`.
227230

228231
### Documentation and NAMESPACE Polishing
@@ -252,7 +255,7 @@
252255
`estimate_multinomial_rsp`, `decorate_grob_set`, `extreme_format`, `fit_rsp_step`,
253256
`fit_survival_step`, `footnotes`, `footnotes-set`,
254257
`format_count_fraction`, `format_fraction_threshold`, `formatting_functions`,
255-
`format_fraction`, `combination_function` (S4 method), `compare_variables` (S3 method),
258+
`format_fraction`, `combination_function` (S4 method), `compare_variables` (S3 method),
256259
`kaplan_meier`.
257260
* Internal keywords added, export removed, `_pkgdown.yml` updated, and `tern:::` added for
258261
tests/examples/vignettes where present for the following functions:
@@ -287,24 +290,24 @@
287290
* Fixed empty vector exception for `cut_quantile_bins`.
288291
* Fixed exception error when empty strings are present in pivoted columns (`rtables` split
289292
functions)
290-
* Fixed bug in `s_ancova` causing an error when the first level of the arm
291-
factor is not the control arm.
293+
* Fixed bug in `s_ancova` causing an error when the first level of the arm
294+
factor is not the control arm.
292295
* Fixed bug in `s_abnormal_by_worst_grade` when there is one `PARAM` level.
293296
* Fixed bug in `prop_diff_wald` when selecting all responders, updated tests accordingly.
294297
* Fixed bug in `h_ancova` that caused an error when deselecting all covariates.
295298

296299
### Miscellaneous
297300
* Added deprecated badge to `g_mmrm`.
298-
* Removed internal function calls in examples (`tern:::`) and added `dontrun`
301+
* Removed internal function calls in examples (`tern:::`) and added `dontrun`
299302
to internal function examples.
300303
* Removed warnings and messages to console occurring in examples and tests.
301-
* Deprecated functions `color_palette` and `h_set_nest_theme` in favor of
304+
* Deprecated functions `color_palette` and `h_set_nest_theme` in favor of
302305
`nestcolor::color_palette` and `nestcolor::theme_nest`, respectively.
303-
* Removed deprecated functions: `color_palette`, `color_palette_core`,
306+
* Removed deprecated functions: `color_palette`, `color_palette_core`,
304307
`h_set_nest_theme`, `s_cox_univariate`.
305-
* Removed deprecated `mmrm` functions: `fit_mmrm`, `g_mmrm_diagnostic`,
306-
`g_mmrm_lsmeans`, `as.rtable.mmrm`, `h_mmrm_fixed`, `h_mmrm_cov`,
307-
`h_mmrm_diagnostic`, `tidy.mmrm`, `s_mmrm_lsmeans`, `s_mmrm_lsmeans_single`,
308+
* Removed deprecated `mmrm` functions: `fit_mmrm`, `g_mmrm_diagnostic`,
309+
`g_mmrm_lsmeans`, `as.rtable.mmrm`, `h_mmrm_fixed`, `h_mmrm_cov`,
310+
`h_mmrm_diagnostic`, `tidy.mmrm`, `s_mmrm_lsmeans`, `s_mmrm_lsmeans_single`,
308311
`summarize_lsmeans`.
309312
* Renamed functions `arm` to `study_arm` and `extract` to `extract_by_name`.
310313
* Renamed `rtables.R` to `utils_rtables.R`.

0 commit comments

Comments
 (0)