Skip to content

Commit 99dcea4

Browse files
committed
fix(ci): Arguments sequence to send Slack announcement.
Signed-off-by: Paulo Vital <[email protected]>
1 parent 952b69c commit 99dcea4

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

.github/scripts/announce_pr_on_slack.py

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,20 @@ def send_slack_message(
2525

2626
data = {"text": message}
2727

28-
try:
29-
with httpx.Client() as client:
30-
response = client.post(url, headers=headers, json=data)
31-
response.raise_for_status()
28+
ret = False
29+
with httpx.Client() as client:
30+
response = client.post(url, headers=headers, json=data)
31+
response.raise_for_status()
3232

33-
result = response.text
34-
if "ok" in result:
35-
print("✅ Slack message sent successfully")
36-
return True
37-
else:
38-
print(f"❌ Slack API error: {result}")
39-
return False
33+
result = response.text
34+
if "ok" in result:
35+
print("✅ Slack message sent successfully")
36+
ret = True
37+
else:
38+
print(f"❌ Slack API error: {result}")
39+
ret = False
4040

41-
except httpx.HTTPError as e:
42-
print(f"❌ Request error: {e}")
43-
return False
41+
return ret
4442

4543

4644
def ensure_environment_variables_are_present() -> (
@@ -139,7 +137,7 @@ def main() -> None:
139137
)
140138

141139
# Send to Slack
142-
success = send_slack_message(slack_service, slack_team, slack_token, message)
140+
success = send_slack_message(slack_team, slack_service, slack_token, message)
143141

144142
if not success:
145143
sys.exit(1)

0 commit comments

Comments
 (0)