[bugfix] fix definitionId type in ImportDefinition

breakone · web-flow · commit e3744496fda4 · 2024-07-17T16:18:30.000+02:00
diff --git a/src/DataDefinitionsBundle/Model/ImportDefinition.php b/src/DataDefinitionsBundle/Model/ImportDefinition.php
@@ -86,15 +86,15 @@ class ImportDefinition extends AbstractDataDefinition implements ImportDefinitio
      */
     public $persister;
 
-    public static function getById(int $name)
+    public static function getById(int|string $name)
     {
         return static::getByName((string)$name);
     }
 
     public static function getByName(string $id)
     {
         $definitionEntry = new ImportDefinition();
-        $definitionEntry->setId((int)$id);
+        $definitionEntry->setId($id);
         /**
          * @var \Instride\Bundle\DataDefinitionsBundle\Model\ExportDefinition\Dao|\Instride\Bundle\DataDefinitionsBundle\Model\ImportDefinition\Dao
          */

Original file line number	Diff line number	Diff line change
`@@ -86,15 +86,15 @@ class ImportDefinition extends AbstractDataDefinition implements ImportDefinitio`
`86`	`86`	`*/`
`87`	`87`	`public $persister;`
`88`	`88`
`89`		`- public static function getById(int $name)`
	`89`	`+ public static function getById(int\|string $name)`
`90`	`90`	`{`
`91`	`91`	`return static::getByName((string)$name);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`public static function getByName(string $id)`
`95`	`95`	`{`
`96`	`96`	`$definitionEntry = new ImportDefinition();`
`97`		`- $definitionEntry->setId((int)$id);`
	`97`	`+ $definitionEntry->setId($id);`
`98`	`98`	`/**`
`99`	`99`	`* @var \Instride\Bundle\DataDefinitionsBundle\Model\ExportDefinition\Dao\|\Instride\Bundle\DataDefinitionsBundle\Model\ImportDefinition\Dao`
`100`	`100`	`*/`